From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44038)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1YNGYQ-0004TK-AR
	for qemu-devel@nongnu.org; Mon, 16 Feb 2015 02:57:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1YNGYM-0007oV-BD
	for qemu-devel@nongnu.org; Mon, 16 Feb 2015 02:57:18 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39076)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1YNGYM-0007o8-3q
	for qemu-devel@nongnu.org; Mon, 16 Feb 2015 02:57:14 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <87a90hoiup.fsf@blackfin.pond.sub.org>
	<20150213225421.GB30518@voom.redhat.com> <54DF4B6F.9010301@redhat.com>
	<20150215030231.GC30518@voom.redhat.com>
	<CAFEAcA9vRNuuUohokg4b1Pc_5g0NLJuj2BwC66=cJWC5fT53HA@mail.gmail.com>
Date: Mon, 16 Feb 2015 08:57:04 +0100
In-Reply-To: <CAFEAcA9vRNuuUohokg4b1Pc_5g0NLJuj2BwC66=cJWC5fT53HA@mail.gmail.com>
	(Peter Maydell's message of "Sun, 15 Feb 2015 11:12:06 +0000")
Message-ID: <87sie6qofj.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] Did we lose monitor commands pci_add, pci_del?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, David Gibson <david@gibson.dropbear.id.au>

Peter Maydell <peter.maydell@linaro.org> writes:

> On 15 February 2015 at 03:02, David Gibson <david@gibson.dropbear.id.au> wrote:
>> Godammit.  Have I mentioned lately how much it pisses me off that we
>> have various config symbols and it's never clear which ones make it
>> into C and which are only in make.
>
> That does seem confusing. Is there a reason we can't have a
> config-devices.h which gets created from config-devices.mak?

Newsflash: homespun configuration system confusing, film at eleven.

(Autoconf is also confusing, but at least it's the same confusion
everywhere)

Back to serious: patching configure to make sure all the CONFIG_ make
variables make it into header files sounds good to me.

With #ifdef tests, forgetting to include the header switches things off.
A single header makes guarding against that mistake easier: every .c
needs to include it first, check with grep.