From: arno@natisbad.org (Arnaud Ebalard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv6 10/10] arm: mvebu: add .dts file for Synology DS414
Date: Sat, 22 Nov 2014 08:41:10 +0100 [thread overview]
Message-ID: <87sihbfzs9.fsf@natisbad.org> (raw)
In-Reply-To: <546FFE9D.2000502@killerwolves.net> (Ben Peddell's message of "Sat, 22 Nov 2014 13:10:21 +1000")
Hi Ben,
Ben Peddell <klightspeed@killerwolves.net> writes:
> On 22/11/14 09:46, Arnaud Ebalard wrote:
>> +
>> + syno_id_bit0_pin: syno-id-bit0-pin {
>> + marvell,pins = "mpp26";
>> + marvell,function = "gpio";
>> + };
>> +
>> + pmx_syno_id_bit1: syno-id-bit1-pin {
>> + marvell,pins = "mpp28";
>> + marvell,function = "gpio";
>> + };
>> +
>> + pmx_syno_id_bit2: syno-id-bit2-pin {
>> + marvell,pins = "mpp29";
>> + marvell,function = "gpio";
>> + };
>> +
>> + pmx_fan1_alarm: fan1-alarm-pin {
>> + marvell,pins = "mpp33";
>> + marvell,function = "gpio";
>> + };
>
> It looks like you forgot to replace pmx_* with *_pin here.
Indeed. Weird it went unnoticed during compilation. Thanks for
pointing it, Ben.
Cheers,
a+
WARNING: multiple messages have this Message-ID (diff)
From: arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org (Arnaud Ebalard)
To: Ben Peddell <klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org>
Cc: Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCHv6 10/10] arm: mvebu: add .dts file for Synology DS414
Date: Sat, 22 Nov 2014 08:41:10 +0100 [thread overview]
Message-ID: <87sihbfzs9.fsf@natisbad.org> (raw)
In-Reply-To: <546FFE9D.2000502-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org> (Ben Peddell's message of "Sat, 22 Nov 2014 13:10:21 +1000")
Hi Ben,
Ben Peddell <klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org> writes:
> On 22/11/14 09:46, Arnaud Ebalard wrote:
>> +
>> + syno_id_bit0_pin: syno-id-bit0-pin {
>> + marvell,pins = "mpp26";
>> + marvell,function = "gpio";
>> + };
>> +
>> + pmx_syno_id_bit1: syno-id-bit1-pin {
>> + marvell,pins = "mpp28";
>> + marvell,function = "gpio";
>> + };
>> +
>> + pmx_syno_id_bit2: syno-id-bit2-pin {
>> + marvell,pins = "mpp29";
>> + marvell,function = "gpio";
>> + };
>> +
>> + pmx_fan1_alarm: fan1-alarm-pin {
>> + marvell,pins = "mpp33";
>> + marvell,function = "gpio";
>> + };
>
> It looks like you forgot to replace pmx_* with *_pin here.
Indeed. Weird it went unnoticed during compilation. Thanks for
pointing it, Ben.
Cheers,
a+
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-11-22 7:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 23:45 [PATCHv6 00/10] arm: mvebu: add Synology DS213j and DS414 .dts files Arnaud Ebalard
2014-11-21 23:45 ` Arnaud Ebalard
2014-11-21 23:45 ` [PATCHv6 01/10] arm: mvebu: fix vendor prefix typo in kirkwood-synology.dtsi Arnaud Ebalard
2014-11-21 23:45 ` Arnaud Ebalard
2014-11-21 23:45 ` [PATCHv6 02/10] arm: mvebu: add uartX labels for Armada SoC serial nodes Arnaud Ebalard
2014-11-21 23:45 ` Arnaud Ebalard
2014-11-21 23:45 ` [PATCHv6 03/10] arm: mvebu: use recently introduced uart label for stdout-path Arnaud Ebalard
2014-11-21 23:45 ` Arnaud Ebalard
2014-11-21 23:45 ` [PATCHv6 04/10] arm: mvebu: move Armada 370/XP pinctrl node definition armada-370-xp.dtsi Arnaud Ebalard
2014-11-21 23:45 ` Arnaud Ebalard
2014-11-21 23:46 ` [PATCHv6 05/10] arm: mvebu: define and use common Armada 370 SPI pinctrl settings Arnaud Ebalard
2014-11-21 23:46 ` Arnaud Ebalard
2014-11-21 23:46 ` [PATCHv6 06/10] arm: mvebu: define and use common Armada 370 UART " Arnaud Ebalard
2014-11-21 23:46 ` Arnaud Ebalard
2014-11-21 23:46 ` [PATCHv6 07/10] arm: mvebu: define and use common Armada XP UART2/3 " Arnaud Ebalard
2014-11-21 23:46 ` Arnaud Ebalard
2014-11-21 23:46 ` [PATCHv6 08/10] arm: mvebu: define and use common Armada XP SPI pinctrl setting Arnaud Ebalard
2014-11-21 23:46 ` Arnaud Ebalard
2014-11-21 23:46 ` [PATCHv6 09/10] arm: mvebu: add .dts file for Synology DS213j Arnaud Ebalard
2014-11-21 23:46 ` Arnaud Ebalard
2014-11-21 23:46 ` [PATCHv6 10/10] arm: mvebu: add .dts file for Synology DS414 Arnaud Ebalard
2014-11-21 23:46 ` Arnaud Ebalard
2014-11-22 3:10 ` Ben Peddell
2014-11-22 3:10 ` Ben Peddell
2014-11-22 7:41 ` Arnaud Ebalard [this message]
2014-11-22 7:41 ` Arnaud Ebalard
2014-11-22 4:54 ` [PATCHv6 00/10] arm: mvebu: add Synology DS213j and DS414 .dts files Jason Cooper
2014-11-22 4:54 ` Jason Cooper
2014-11-22 8:13 ` Arnaud Ebalard
2014-11-22 8:13 ` Arnaud Ebalard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sihbfzs9.fsf@natisbad.org \
--to=arno@natisbad.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.