From: Rusty Russell <rusty@rustcorp.com.au>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: virtualization@lists.linux-foundation.org,
Sebastian Ott <sebott@linux.vnet.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] virtio_ccw: remove unsued variable
Date: Fri, 31 Oct 2014 10:31:19 +1030 [thread overview]
Message-ID: <87sii585v4.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20141030185126.1da79c12.cornelia.huck@de.ibm.com>
Cornelia Huck <cornelia.huck@de.ibm.com> writes:
> On Tue, 28 Oct 2014 19:37:58 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
>> On Tue, Oct 28, 2014 at 04:39:12PM +0100, Sebastian Ott wrote:
>
>> > virtio_ccw: remove unused variable
>> >
>> > Fix this warning:
>> > drivers/s390/kvm/virtio_ccw.c: In function ‘virtio_ccw_int_handler’:
>> > drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ‘drv’ [-Wunused-variable]
>> > struct virtio_driver *drv;
>> >
>> > Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
>> > Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>>
>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>>
>> > ---
>> > drivers/s390/kvm/virtio_ccw.c | 1 -
>> > 1 file changed, 1 deletion(-)
>> >
>> > diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c
>> > index 6cbe6ef..bda52f1 100644
>> > --- a/drivers/s390/kvm/virtio_ccw.c
>> > +++ b/drivers/s390/kvm/virtio_ccw.c
>> > @@ -888,7 +888,6 @@ static void virtio_ccw_int_handler(struct ccw_device *cdev,
>> > struct virtio_ccw_device *vcdev = dev_get_drvdata(&cdev->dev);
>> > int i;
>> > struct virtqueue *vq;
>> > - struct virtio_driver *drv;
>> >
>> > if (!vcdev)
>> > return;
>
> *pokes Rusty*
>
> Do you want to send this via the virtio tree? Otherwise, I'll queue
> this with kvm/s390.
*Rusty wakes*.
I assumed you would take it when I skimmed the patch, but to be formal:
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Sorry for the delay,
Rusty.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2014-10-31 0:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 10:48 [PATCH] virtio_ccw: remove unsued variable Sebastian Ott
2014-10-20 11:05 ` Cornelia Huck
2014-10-20 14:19 ` Michael S. Tsirkin
2014-10-28 15:39 ` Sebastian Ott
2014-10-28 17:37 ` Michael S. Tsirkin
2014-10-30 17:51 ` Cornelia Huck
2014-10-31 0:01 ` Rusty Russell [this message]
2014-10-31 8:10 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sii585v4.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=cornelia.huck@de.ibm.com \
--cc=mst@redhat.com \
--cc=sebott@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.