From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753537AbaJGLQ2 (ORCPT ); Tue, 7 Oct 2014 07:16:28 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:41566 "EHLO e06smtp17.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753194AbaJGLQ0 (ORCPT ); Tue, 7 Oct 2014 07:16:26 -0400 From: Alexander Yarygin To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Paul Mackerras , Namhyung Kim , LKML , Jiri Olsa , David Ahern Subject: Re: [PATCH 3/3] perf kvm: Print kvm specific --help output References: <1412669432-14833-1-git-send-email-namhyung@kernel.org> <1412669432-14833-3-git-send-email-namhyung@kernel.org> Date: Tue, 07 Oct 2014 15:16:19 +0400 In-Reply-To: <1412669432-14833-3-git-send-email-namhyung@kernel.org> (Namhyung Kim's message of "Tue, 7 Oct 2014 17:10:32 +0900") Message-ID: <87sij0f7uk.fsf@linux.vnet.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14100711-0542-0000-0000-000001165437 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Namhyung Kim writes: > The 'perf kvm stat record' tool is an alias of 'perf record' with > predefined kvm related options. All options that passed to 'perf kvm > stat record' are processed by the 'perf record' tool. So, 'perf kvm > stat record --help' prints help of usage for the 'perf record' > command. There are a few options useful for 'perf kvm stat record', > the rest either break kvm related output or don't change it. > > Let's print safe for 'perf kvm stat record' options in addition to > general 'perf record' --help output. We probably want s/in addition to general 'perf record' --help output// > > With this patch, new output looks like below: > > $ perf kvm stat record -h > > usage: perf kvm stat record [] > > -p, --pid record events on existing process id > -t, --tid record events on existing thread id > -r, --realtime collect data with this RT SCHED_FIFO priority > --no-buffering collect data without buffering > -a, --all-cpus system-wide collection from all CPUs > -C, --cpu list of cpus to monitor > -c, --count event period to sample > -o, --output output file name > -i, --no-inherit child tasks do not inherit counters > -m, --mmap-pages > number of mmap data pages > -v, --verbose be more verbose (show counter open errors, etc) > -q, --quiet don't print any message > -s, --stat per thread counts > -D, --delay ms to wait before starting measurement after program start > -u, --uid user to profile > --per-thread use per-thread mmaps > > $ perf kvm stat record -n sleep 1 > Error: switch `n' is not usable > > usage: perf kvm stat record [] > > Cc: Alexander Yarygin > Signed-off-by: Namhyung Kim > --- > tools/perf/builtin-kvm.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c > index 460a4ce9c044..c029d0fdc93e 100644 > --- a/tools/perf/builtin-kvm.c > +++ b/tools/perf/builtin-kvm.c > @@ -1132,6 +1132,10 @@ kvm_events_record(struct perf_kvm_stat *kvm, int argc, const char **argv) > "-m", "1024", > "-c", "1", > }; > + const char * const kvm_stat_record_usage[] = { > + "perf kvm stat record []", > + NULL > + }; > const char * const *events_tp; > events_tp_size = 0; > > @@ -1159,6 +1163,27 @@ kvm_events_record(struct perf_kvm_stat *kvm, int argc, const char **argv) > for (j = 1; j < (unsigned int)argc; j++, i++) > rec_argv[i] = argv[j]; > > + set_option_flag(record_options, 'e', "event", PARSE_OPT_HIDDEN); > + set_option_flag(record_options, 0, "filter", PARSE_OPT_HIDDEN); > + set_option_flag(record_options, 'R', "raw-samples", PARSE_OPT_HIDDEN); > + > + set_option_flag(record_options, 'F', "freq", PARSE_OPT_DISABLED); > + set_option_flag(record_options, 0, "group", PARSE_OPT_DISABLED); > + set_option_flag(record_options, 'g', NULL, PARSE_OPT_DISABLED); > + set_option_flag(record_options, 0, "call-graph", PARSE_OPT_DISABLED); > + set_option_flag(record_options, 'd', "data", PARSE_OPT_DISABLED); > + set_option_flag(record_options, 'T', "timestamp", PARSE_OPT_DISABLED); > + set_option_flag(record_options, 'P', "period", PARSE_OPT_DISABLED); > + set_option_flag(record_options, 'n', "no-samples", PARSE_OPT_DISABLED); > + set_option_flag(record_options, 'N', "no-buildid-cache", PARSE_OPT_DISABLED); > + set_option_flag(record_options, 'B', "no-buildid", PARSE_OPT_DISABLED); > + set_option_flag(record_options, 'G', "cgroup", PARSE_OPT_DISABLED); > + set_option_flag(record_options, 'b', "branch-any", PARSE_OPT_DISABLED); > + set_option_flag(record_options, 'j', "branch-filter", PARSE_OPT_DISABLED); > + set_option_flag(record_options, 'W', "weight", PARSE_OPT_DISABLED); > + set_option_flag(record_options, 0, "transaction", PARSE_OPT_DISABLED); > + > + record_usage = kvm_stat_record_usage; > return cmd_record(i, rec_argv, NULL); > } Otherwise it works for me. Thanks!