From: Namhyung Kim <namhyung@kernel.org>
To: John Spencer <maillist-linux@barfooze.de>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] perf Makefile: fix GNU-only grep usage
Date: Tue, 26 Aug 2014 15:46:32 +0900 [thread overview]
Message-ID: <87sikjbvef.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <53FB9040.8060802@barfooze.de> (John Spencer's message of "Mon, 25 Aug 2014 21:36:32 +0200")
Hi John,
You'd better to CC the lkml (linux-kernel@vger.kernel.org) for the perf
patches to get reviewed by other developers. I'm copying to the list
this time.
On Mon, 25 Aug 2014 21:36:32 +0200, John Spencer wrote:
> From efa79d5b7bc750369332a3a34442573af7b1b35c Mon Sep 17 00:00:00 2001
> From: John Spencer <maillist-linux@barfooze.de>
> Date: Mon, 25 Aug 2014 21:24:30 +0200
> Subject: [PATCH 1/2] perf Makefile: fix GNU-only grep usage
>
> this makes it work with non-GNU grep's as well.
>
> Signed-off-by: John Spencer <maillist-linux@barfooze.de>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
>
> ---
> tools/perf/config/utilities.mak | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/config/utilities.mak b/tools/perf/config/utilities.mak
> index 4d985e0..7076a62 100644
> --- a/tools/perf/config/utilities.mak
> +++ b/tools/perf/config/utilities.mak
> @@ -132,7 +132,7 @@ endef
> #
> # Usage: bool-value = $(call is-absolute,path)
> #
> -is-absolute = $(shell echo $(shell-sq) | grep ^/ -q && echo y)
> +is-absolute = $(shell echo $(shell-sq) | grep -q ^/ && echo y)
>
> # lookup
> #
prev parent reply other threads:[~2014-08-26 6:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 19:36 [PATCH 1/2] perf Makefile: fix GNU-only grep usage John Spencer
2014-08-26 6:46 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sikjbvef.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maillist-linux@barfooze.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.