From: Jani Nikula <jani.nikula@linux.intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()
Date: Mon, 18 Aug 2014 11:04:59 +0300 [thread overview]
Message-ID: <87sikunrys.fsf@intel.com> (raw)
In-Reply-To: <1408124046-12328-1-git-send-email-damien.lespiau@intel.com>
On Fri, 15 Aug 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> Chris has decided that enough is enough. It's time to fixup dev Vs
> dev_priv and the, oh so awful, INTEL_INFO(). This is a modest
> contribution to the crusade.
> -#define for_each_pipe(p) for ((p) = 0; (p) < INTEL_INFO(dev)->num_pipes; (p)++)
> +#define for_each_pipe(dev, p) for ((p) = 0; (p) < (dev)->info.num_pipes; (p)++)
Naming the first argument "dev" disagrees with the subject.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
prev parent reply other threads:[~2014-08-18 8:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-15 17:34 [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe() Damien Lespiau
2014-08-15 18:15 ` Chris Wilson
2014-08-18 10:00 ` Damien Lespiau
2014-08-18 10:07 ` Chris Wilson
2014-08-18 12:49 ` Damien Lespiau
2014-08-18 12:58 ` Chris Wilson
2014-08-18 13:07 ` Damien Lespiau
2014-08-18 13:13 ` Chris Wilson
2014-08-26 7:40 ` Daniel Vetter
2014-08-18 8:04 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sikunrys.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.