All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bill Pringlemeir <bpringlemeir@nbsps.com>
To: hujianyang <hujianyang@huawei.com>
Cc: Richard Weinberger <richard.weinberger@gmail.com>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH RFC v2] UBI: New ioctl() to support ubidump
Date: Wed, 30 Jul 2014 11:53:09 -0400	[thread overview]
Message-ID: <87siliu9lm.fsf@nbsps.com> (raw)
In-Reply-To: <53D85203.7030302@huawei.com> (hujianyang@huawei.com's message of "Wed, 30 Jul 2014 10:01:39 +0800")

On 29 Jul 2014, hujianyang@huawei.com wrote:

> But I'm worry about the performance. As we dump one specified peb
> now, we can't record the mapping table and need to do full scan
> each time running this utility.

You can record the table if you know that the MTD is not changing.  If
you introduce the 'ioctl()' to the kernel, it will most likely be on an
active file system.  I guess this is a big decision in the tools design.

Supporting an active file system is much more difficult.  For the case
of an real MTD backing store, I was thinking this would run from another
partition or an initramfs; UBI/UbiFS would not be active.  It could
possibly attempt to repair the UBI/UbiFs, while nothing else is using
it.  The other use case is to read out the flash via some tools and
loopback mount it with nandsim on a PC for diagnosis; a post-mortem
analysis.

If you wish to run the utility on an active MTD, I would suggest some
'freeze/thaw' type function to stop UBI/UbiFs and then just use the tool
on the 'frozen' MTD.  Maybe this exists already for suspend/resume or
something else.  It might only be a debug type interface; so
conditionally compiled for developers.  It needs a hook so you can
trigger the freeze on some condition via code.

I think others don't understand why you would want the 'ubidump' to run
on an active file system?  At least, I don't understand this?  Is there
some use case we are missing?  I am quite sure that you can perform
better diagnostics on a 'frozen' image where you can look at the whole
image state.

Fwiw,
Bill Pringlemeir.

  reply	other threads:[~2014-07-30 16:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-29  9:20 [PATCH RFC v2] ubi-utils: Introduce a utility ubidump hujianyang
2014-07-29  9:26 ` [PATCH RFC v2] UBI: New ioctl() to support ubidump hujianyang
2014-07-29 14:48   ` Bill Pringlemeir
2014-07-30  2:01     ` hujianyang
2014-07-30 15:53       ` Bill Pringlemeir [this message]
2014-07-31  3:01         ` hujianyang
2014-07-31 13:24           ` Artem Bityutskiy
2014-08-01  2:50             ` hujianyang
2014-08-01  7:30               ` Artem Bityutskiy
2014-08-01 10:10                 ` hujianyang
2014-08-01 15:35                 ` Bill Pringlemeir
2014-08-04  3:54                   ` hujianyang
2014-08-05 21:10                     ` Bill Pringlemeir
2014-07-31 13:25         ` Artem Bityutskiy
2014-07-29 16:37   ` Richard Weinberger
2014-07-30  2:19     ` hujianyang
2014-07-29  9:31 ` [PATCH 1/5] ubi-utils: Add libdump files hujianyang
2014-07-29  9:35 ` [PATCH 2/5] ubi-utils: Enable lnum2pnum ioctl in userspace hujianyang
2014-07-29  9:41 ` [PATCH 3/5] ubi-utils: Introduce ubidump hujianyang
2014-07-29  9:43 ` [PATCH 4/5] ubi-utils: Add ubifs-media.h hujianyang
2014-07-29  9:45 ` [PATCH 5/5] ubi-utils: Modified Makefile hujianyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87siliu9lm.fsf@nbsps.com \
    --to=bpringlemeir@nbsps.com \
    --cc=dedekind1@gmail.com \
    --cc=hujianyang@huawei.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard.weinberger@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.