From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60482)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1X43Mp-00078W-32
	for qemu-devel@nongnu.org; Mon, 07 Jul 2014 03:29:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1X43Mj-0001mi-63
	for qemu-devel@nongnu.org; Mon, 07 Jul 2014 03:29:39 -0400
Received: from oxygen.pond.sub.org ([144.76.244.19]:43839)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1X43Mi-0001mb-Vh
	for qemu-devel@nongnu.org; Mon, 07 Jul 2014 03:29:33 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1400588941-12347-1-git-send-email-stefanha@redhat.com>
	<53B7C1E3.1010103@redhat.com> <53B99D99.5050304@redhat.com>
	<53BA4443.8000801@redhat.com>
Date: Mon, 07 Jul 2014 09:29:29 +0200
In-Reply-To: <53BA4443.8000801@redhat.com> (Paolo Bonzini's message of "Mon,
	07 Jul 2014 08:54:59 +0200")
Message-ID: <87simd4ofa.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] qmp: show QOM properties in
	device-list-properties
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Andreas Faerber <afaerber@suse.de>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Cole Robinson <crobinso@redhat.com>

Paolo Bonzini <pbonzini@redhat.com> writes:

> Il 06/07/2014 21:03, Cole Robinson ha scritto:
>> On 07/05/2014 05:14 AM, Paolo Bonzini wrote:
>>> Il 20/05/2014 14:29, Stefan Hajnoczi ha scritto:
>>>> Devices can use a mix of qdev and QOM properties.  Currently only the
>>>> qdev properties are displayed by device-list-properties.
>>>>
>>>> This patch extends the property enumeration algorithm to also display
>>>> QOM properties (excluding the implicit "type", "realized",
>>>> "hotpluggable", and "parent_bus" properties).
>>>>
>>>> When a qdev property exists, use the qdev type name to preserve
>>>> backwards compatibility.  QOM type names can be different for bool (qdev
>>>> on/off) and str (used by qdev pointers).
>>>>
>>>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>>
>>>
>>> Stefan, was this never applied?
>>>
>>
>> I assume you CC'd me in reference to the bug I reported:
>>
>> https://lists.gnu.org/archive/html/qemu-devel/2014-07/msg00882.html
>>
>> I tested this patch, but it doesn't fix the specific bit I mentioned (lack of
>> 'bootindex' in -device virtio-blk,? )
>
> Yes, it doesn't, but does libvirt work then?  I'm not sure if libvirt
> still uses -device or rather device-list-properties (which lets you
> start a single QEMU process and do multiple probes).

Valid question, but of course we need to fix the -device FOO,help
regression regardless.