From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43870)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1X0BkS-0001dY-In
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 11:38:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1X0BkJ-0003Gq-Ic
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 11:38:04 -0400
Received: from oxygen.pond.sub.org ([2a01:4f8:201:233:1::3]:33457)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1X0BkJ-0003GZ-CU
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 11:37:55 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1403073840-32603-1-git-send-email-pbonzini@redhat.com>
	<1403073840-32603-22-git-send-email-pbonzini@redhat.com>
Date: Thu, 26 Jun 2014 17:37:49 +0200
In-Reply-To: <1403073840-32603-22-git-send-email-pbonzini@redhat.com> (Paolo
	Bonzini's message of "Wed, 18 Jun 2014 08:43:45 +0200")
Message-ID: <87simrd6lu.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert
	BLOCK_IO_ERROR and BLOCK_JOB_ERROR
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: lcapitulino@redhat.com, qemu-devel@nongnu.org, wenchaoqemu@gmail.com

Paolo Bonzini <pbonzini@redhat.com> writes:

> From: Wenchao Xia <wenchaoqemu@gmail.com>
>
> Signed-off-by: Wenchao Xia <wenchaoqemu@gmail.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

This broke tests/qemu-iotests/041.  Apparently, the BLOCK_JOB_ERROR
event changed from

    {'timestamp': {'seconds': 1403796871, 'microseconds': 446502},
     'data': {'device': 'drive0',
              'action': 'ignore',
              'operation': 'write'},
     'event': 'BLOCK_JOB_ERROR'}

to

    {'timestamp': {'seconds': 1403796674, 'microseconds': 63271},
     'data': {'device': '',
              'action': 'report',
              'operation': 'write'},
     'event': 'BLOCK_JOB_ERROR'}

losing the value of device, which breaks qemu-iotests/041's tests of
data/device.

Please fix.