All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Michal Marek <mmarek@suse.cz>, Andi Kleen <ak@linux.intel.com>,
	Christian Engelmayer <cengelma@gmx.at>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] modpost: Fix ressource leak in read_dump()
Date: Tue, 22 Apr 2014 16:56:41 +0930	[thread overview]
Message-ID: <87sip5hlji.fsf@rustcorp.com.au> (raw)
In-Reply-To: <53441149.8010902@suse.cz>

Michal Marek <mmarek@suse.cz> writes:

> On 2014-04-06 02:05, Andi Kleen wrote:
>> On Sun, Apr 06, 2014 at 12:36:49AM +0200, Christian Engelmayer wrote:
>>> Function read_dump() memory maps the input via grab_file(), but fails to call
>>> the corresponding unmap function. Add the missing call to release_file().
>>> Detected by Coverity: CID 1192419
>> 
>> It doesn't matter at all. All memory is freed on exit() in this program.
>
> The leak can disturb in valgrind output.

Yeah.  If release_file() didn't exist at all, I'd agree with Andi.  As
it is, I've queued the patch (with typo in title fixed).

Thanks!
Rusty.

      reply	other threads:[~2014-04-22  7:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-05 22:36 [PATCH] modpost: Fix ressource leak in read_dump() Christian Engelmayer
2014-04-06  0:05 ` Andi Kleen
2014-04-08 15:10   ` Michal Marek
2014-04-22  7:26     ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sip5hlji.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=ak@linux.intel.com \
    --cc=cengelma@gmx.at \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.