All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Yeoh Chun-Yeow <yeohchunyeow@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	Michal Kazior <michal.kazior@tieto.com>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH v5] ath10k: implement per-VDEV FW statistics
Date: Fri, 28 Mar 2014 16:28:53 +0200	[thread overview]
Message-ID: <87siq2v1lm.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CAEFj985Xq-_QRmdOsFKEM0kA40TpgKL6t1DW8yXSPY6dn=R2LA@mail.gmail.com> (Yeoh Chun-Yeow's message of "Fri, 28 Mar 2014 22:24:33 +0800")

Yeoh Chun-Yeow <yeohchunyeow@gmail.com> writes:

> On Fri, Mar 28, 2014 at 10:06 PM, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>> Michal Kazior <michal.kazior@tieto.com> writes:
>>
>>> On 28 March 2014 14:28, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>>>> From: Bartosz Markowski <bartosz.markowski@tieto.com>
>>>>
>>>> The WMI_REQUEST_PEER_STAT command with latest (999.999.0.716) FW
>>>> can return per-VDEV statistics. Using debugfs we can fetch this info now.
>>>>
>>>> This is a backward compatible change. In case of older FW the VDEV
>>>> statistics are simply not returned.
>>>>
>>>> kvalo: remove struct wmi_peer_stats_common cast from
>>>> ath10k_debug_read_target_stats()
>>>
>>> I just glanced over the patch and I don't think this is correct.
>>>
>>> Firmware 10.1.467 has peer_rx_rate but doesn't seem to have vdev stats.
>>
>> Ok, I need to take a closer look at this. If someone else wants to look
>> at this instead, feel free to do that :)
>>
> I up two AP interfaces in same physical but not able to see two
> different vdev in get stats.

That's because the firmware image have doesn't have the feature bit set.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Yeoh Chun-Yeow <yeohchunyeow@gmail.com>
Cc: Michal Kazior <michal.kazior@tieto.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH v5] ath10k: implement per-VDEV FW statistics
Date: Fri, 28 Mar 2014 16:28:53 +0200	[thread overview]
Message-ID: <87siq2v1lm.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CAEFj985Xq-_QRmdOsFKEM0kA40TpgKL6t1DW8yXSPY6dn=R2LA@mail.gmail.com> (Yeoh Chun-Yeow's message of "Fri, 28 Mar 2014 22:24:33 +0800")

Yeoh Chun-Yeow <yeohchunyeow@gmail.com> writes:

> On Fri, Mar 28, 2014 at 10:06 PM, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>> Michal Kazior <michal.kazior@tieto.com> writes:
>>
>>> On 28 March 2014 14:28, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>>>> From: Bartosz Markowski <bartosz.markowski@tieto.com>
>>>>
>>>> The WMI_REQUEST_PEER_STAT command with latest (999.999.0.716) FW
>>>> can return per-VDEV statistics. Using debugfs we can fetch this info now.
>>>>
>>>> This is a backward compatible change. In case of older FW the VDEV
>>>> statistics are simply not returned.
>>>>
>>>> kvalo: remove struct wmi_peer_stats_common cast from
>>>> ath10k_debug_read_target_stats()
>>>
>>> I just glanced over the patch and I don't think this is correct.
>>>
>>> Firmware 10.1.467 has peer_rx_rate but doesn't seem to have vdev stats.
>>
>> Ok, I need to take a closer look at this. If someone else wants to look
>> at this instead, feel free to do that :)
>>
> I up two AP interfaces in same physical but not able to see two
> different vdev in get stats.

That's because the firmware image have doesn't have the feature bit set.

-- 
Kalle Valo

  reply	other threads:[~2014-03-28 14:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-28 13:28 [PATCH v5] ath10k: implement per-VDEV FW statistics Kalle Valo
2014-03-28 13:28 ` Kalle Valo
2014-03-28 13:53 ` Michal Kazior
2014-03-28 13:53   ` Michal Kazior
2014-03-28 14:06   ` Kalle Valo
2014-03-28 14:06     ` Kalle Valo
2014-03-28 14:24     ` Yeoh Chun-Yeow
2014-03-28 14:24       ` Yeoh Chun-Yeow
2014-03-28 14:28       ` Kalle Valo [this message]
2014-03-28 14:28         ` Kalle Valo
2014-03-28 16:07         ` Yeoh Chun-Yeow
2014-03-28 16:07           ` Yeoh Chun-Yeow
2014-03-31  7:14           ` Kalle Valo
2014-03-31  7:14             ` Kalle Valo
2014-03-28 14:23 ` Yeoh Chun-Yeow
2014-03-28 14:23   ` Yeoh Chun-Yeow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87siq2v1lm.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    --cc=yeohchunyeow@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.