Re: [PATCH] drm/i915: Remove erronous WARN in the vlv pipe crc code

From: Jani Nikula <jani.nikula@linux.intel.com>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Remove erronous WARN in the vlv pipe crc code
Date: Thu, 13 Mar 2014 19:52:45 +0200	[thread overview]
Message-ID: <87siqm56ky.fsf@intel.com> (raw)
In-Reply-To: <1394729162-23133-1-git-send-email-daniel.vetter@ffwll.ch>

On Thu, 13 Mar 2014, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> It's been in there since forever, and no one cared. Doesn't put a too
> good light onto our bug handling and QA efforts really ...
>
> References: https://bugs.freedesktop.org/attachment.cgi?id=90970

Is there a bug report for this, or did you just spot this in an
unrelated bug?

BR,
Jani.

> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index d90a70744d93..92eea70ed7b8 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2559,8 +2559,6 @@ static int vlv_pipe_crc_ctl_reg(struct drm_device *dev,
>  	if (need_stable_symbols) {
>  		uint32_t tmp = I915_READ(PORT_DFT2_G4X);
>  
> -		WARN_ON(!IS_G4X(dev));
> -
>  		tmp |= DC_BALANCE_RESET_VLV;
>  		if (pipe == PIPE_A)
>  			tmp |= PIPE_A_SCRAMBLE_RESET;
> -- 
> 1.8.5.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center