From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] Analysis of bug #5030: busybox built fails if we use an override src dir BUSYBOX_OVERRIDE_SRCDIR and that dir does not contain .config
Date: Wed, 12 Feb 2014 20:26:03 +0100 [thread overview]
Message-ID: <87sirorv3o.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <CAAXf6LVADN6CwMA-dtHk3WCYemROMXwPrCntuka9s0nBj2DVkA@mail.gmail.com> (Thomas De Schampheleire's message of "Wed, 12 Feb 2014 11:55:06 +0100")
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:
Hi,
>>> > I also accept the principle of this patch.
>>> >
>>> > As a side note, this behavior of busybox.mk was also problematic when
>>> > trying to implement out of tree build for packages, because .config is
>>> > inherently part of the *build* directory, but the build directory
>>> > doesn't exist yet during the extract step: it is only created at the
>>> > beginning of the configure step. So my out-of-tree patch set contains:
>>> >
>>> > -# We do this here to avoid busting a modified .config in configure
>>> > -BUSYBOX_POST_EXTRACT_HOOKS += BUSYBOX_COPY_CONFIG
>>> > -
>>> > define BUSYBOX_CONFIGURE_CMDS
>>> > + $(BUSYBOX_COPY_CONFIG)
>>> >
>>>
>>> Then maybe we should apply exactly this change, and not the proposed
>>> one that uses a hook?
>>> Additionally, we should then also make this change in uclibc, right?
>>
>> Yes. But I would like to hear Peter's opinion on this.
> Peter, what do you think?
I don't feel strongly about it, but if changing it to "the linux way"
solves problems, then lets do it.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2014-02-12 19:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 20:58 [Buildroot] Analysis of bug #5030: busybox built fails if we use an override src dir BUSYBOX_OVERRIDE_SRCDIR and that dir does not contain .config Thomas De Schampheleire
2014-02-12 8:21 ` Thomas Petazzoni
2014-02-12 10:41 ` Thomas De Schampheleire
2014-02-12 10:51 ` Thomas Petazzoni
2014-02-12 10:55 ` Thomas De Schampheleire
2014-02-12 19:26 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sirorv3o.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.