From: Rusty Russell <rusty@rustcorp.com.au>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Lucas De Marchi <lucas.de.marchi@gmail.com>,
Peter Chen <peter.chen@freescale.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/1] module: Make wait module's refcount to zero procedure as async
Date: Mon, 27 Jan 2014 22:15:23 +1030 [thread overview]
Message-ID: <87sis9zm0c.fsf@rustcorp.com.au> (raw)
In-Reply-To: <alpine.LSU.2.11.1401251550580.4334@nerf08.vanv.qr>
Jan Engelhardt <jengelh@inai.de> writes:
> On Monday 2013-09-16 05:47, Rusty Russell wrote:
>>
>>Here's what I've got in my pending-rebases tree.
>>
>>@@ -842,6 +818,11 @@ SYSCALL_DEFINE2(delete_module, const char __user *, name_user,
>> return -EFAULT;
>> name[MODULE_NAME_LEN-1] = '\0';
>>
>>+ if (!(flags & O_NONBLOCK)) {
>>+ printk(KERN_WARNING
>>+ "waiting module removal not supported: please upgrade");
>>+ }
>>+
>
> This patch has come to my attention via the opensuse lists, where
> a poster reported about this new user-visible message (it appears
> in dmesg!) and rightfully asked: upgrade what component?
>
> It's probably the userspace module loading utility, but it _really_
> should say so. There's good room to read that message - a few months
> into the future - as "upgrade your kernel" instead ;)
True, but honestly I never expected to see it!
Please try to discover what is doing rmmod --wait?
Thanks,
Rusty.
prev parent reply other threads:[~2014-01-27 11:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 3:14 [RFC PATCH 1/1] module: Make wait module's refcount to zero procedure as async Peter Chen
2013-09-13 0:30 ` Rusty Russell
2013-09-13 1:55 ` Peter Chen
2013-09-13 2:08 ` Lucas De Marchi
2013-09-16 3:47 ` Rusty Russell
2013-09-17 22:59 ` Lucas De Marchi
2014-01-25 14:54 ` Jan Engelhardt
2014-01-27 11:45 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sis9zm0c.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=jengelh@inai.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=peter.chen@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.