From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33941)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rusty@ozlabs.org>) id 1V9RNU-0003XI-VX
	for qemu-devel@nongnu.org; Tue, 13 Aug 2013 23:04:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rusty@ozlabs.org>) id 1V9RNQ-000862-32
	for qemu-devel@nongnu.org; Tue, 13 Aug 2013 23:04:04 -0400
Received: from ozlabs.org ([203.10.76.45]:53606)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rusty@ozlabs.org>) id 1V9RNP-00085a-NO
	for qemu-devel@nongnu.org; Tue, 13 Aug 2013 23:03:59 -0400
From: Rusty Russell <rusty@rustcorp.com.au>
In-Reply-To: <1376371812.4255.0.camel@pasglop>
References: <1376294363-4650-1-git-send-email-rusty@rustcorp.com.au>
	<1376294363-4650-2-git-send-email-rusty@rustcorp.com.au>
	<1376299687.32100.159.camel@pasglop>
	<87txivrrsz.fsf@codemonkey.ws> <87a9kmmdca.fsf@rustcorp.com.au>
	<1376371812.4255.0.camel@pasglop>
Date: Wed, 14 Aug 2013 09:33:57 +0930
Message-ID: <87siydkuj6.fsf@rustcorp.com.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for
	endian-ambivalent targets using virtio.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>

Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
> On Tue, 2013-08-13 at 13:50 +0930, Rusty Russell wrote:
>> We can have it call once (eg. when the first and storing the status
>> word) and store the result.
>
> And fail with kexec of a different endian kernel :-) Let's not bother
> yet. Merge it and then we see if we can optimize.

Yeah, my code actually did it every status bye write, which
unintentionally solved this.

But agreed, let's let these patches stand...

Cheers,
Rusty.