Re: [Qemu-devel] [PATCH 4/7] Fix -machine options accel, kernel_irqchip, kvm_shadow_mem

[Markus Armbruster <armbru@redhat.com>]

Peter Maydell <peter.maydell@linaro.org> writes:

> On 4 July 2013 16:58, Markus Armbruster <armbru@redhat.com> wrote:
>> Peter Maydell <peter.maydell@linaro.org> writes:
>>
>>> On 4 July 2013 14:09, Markus Armbruster <armbru@redhat.com> wrote:
>>>> Multiple -machine options with the same ID are merged.  All but the
>>>> one without an ID are to be silently ignored.
>>>
>>> I think it would make more sense just to say that specifying
>>> id= for -machine (or any other merge_lists=true option type)
>>> is not permitted. Or do you have a reason for wanting to
>>> have more than one -machine?
>>
>> Adding even more options to QemuOpts is what I'd rather avoid; I find it
>> ridiculous enough already.
>
> That's why I suggested that we should use the existing
> merge_lists=true rather than adding another option.
>
>> But if y'all want one to outlaw -machine id=..., I can add it.
>
> Given that the latter half of this patchset seems to be dealing
> with the fallout of letting the user specify -machine id=
> it seems simpler just to say "don't do that".

Outlawing -machine id=... turns those patches from fixes of exotic bugs
into cleanup, of pretty much unchanged value.