From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 0/4] rtc: omap: handle rtc wakeup support in driver Date: Mon, 01 Jul 2013 17:18:54 -0700 Message-ID: <87sizxn79t.fsf@linaro.org> References: <1372412109-986-1-git-send-email-gururaja.hebbar@ti.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pa0-f51.google.com ([209.85.220.51]:35734 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755452Ab3GBAS6 (ORCPT ); Mon, 1 Jul 2013 20:18:58 -0400 Received: by mail-pa0-f51.google.com with SMTP id lf11so5633706pab.10 for ; Mon, 01 Jul 2013 17:18:57 -0700 (PDT) In-Reply-To: <1372412109-986-1-git-send-email-gururaja.hebbar@ti.com> (Hebbar Gururaja's message of "Fri, 28 Jun 2013 15:05:05 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Hebbar Gururaja Cc: tony@atomide.com, b-cousson@ti.com, linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, davinci-linux-open-source@linux.davincidsp.com, vaibhav.bedia@ti.com, sudhakar.raj@ti.com Hi Hebbar, Hebbar Gururaja writes: > rtc-omap driver modules is used both by OMAP1/2, Davinci SoC platforms. > > However, rtc wake support on OMAP1 is broken. Hence the > device_init_wakeup() was removed from rtc-omap driver and moved to > platform board files that supported it (DA850/OMAP-L138). [1] > > However, recently [2] it was suggested that driver should always do a > device_init_wakeup(dev, true). Platforms that don't want/need > wakeup support can disable it from userspace via: > > echo disabled > /sys/devices/.../power/wakeup > > Also, with the new DT boot-up, board file doesn't exist and hence there > is no way to have device wakeup support rtc. > > The fix for above issues, is to hard code device_init_wakeup() inside > driver and let platforms that don't need this, handle it through the > sysfs power entry. This series looks good now, thanks for your persistence. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@linaro.org (Kevin Hilman) Date: Mon, 01 Jul 2013 17:18:54 -0700 Subject: [PATCH 0/4] rtc: omap: handle rtc wakeup support in driver In-Reply-To: <1372412109-986-1-git-send-email-gururaja.hebbar@ti.com> (Hebbar Gururaja's message of "Fri, 28 Jun 2013 15:05:05 +0530") References: <1372412109-986-1-git-send-email-gururaja.hebbar@ti.com> Message-ID: <87sizxn79t.fsf@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Hebbar, Hebbar Gururaja writes: > rtc-omap driver modules is used both by OMAP1/2, Davinci SoC platforms. > > However, rtc wake support on OMAP1 is broken. Hence the > device_init_wakeup() was removed from rtc-omap driver and moved to > platform board files that supported it (DA850/OMAP-L138). [1] > > However, recently [2] it was suggested that driver should always do a > device_init_wakeup(dev, true). Platforms that don't want/need > wakeup support can disable it from userspace via: > > echo disabled > /sys/devices/.../power/wakeup > > Also, with the new DT boot-up, board file doesn't exist and hence there > is no way to have device wakeup support rtc. > > The fix for above issues, is to hard code device_init_wakeup() inside > driver and let platforms that don't need this, handle it through the > sysfs power entry. This series looks good now, thanks for your persistence. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932065Ab3GBAS7 (ORCPT ); Mon, 1 Jul 2013 20:18:59 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:36166 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755513Ab3GBAS6 (ORCPT ); Mon, 1 Jul 2013 20:18:58 -0400 From: Kevin Hilman To: Hebbar Gururaja Cc: , , , , , , , , Subject: Re: [PATCH 0/4] rtc: omap: handle rtc wakeup support in driver References: <1372412109-986-1-git-send-email-gururaja.hebbar@ti.com> Date: Mon, 01 Jul 2013 17:18:54 -0700 In-Reply-To: <1372412109-986-1-git-send-email-gururaja.hebbar@ti.com> (Hebbar Gururaja's message of "Fri, 28 Jun 2013 15:05:05 +0530") Message-ID: <87sizxn79t.fsf@linaro.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hebbar, Hebbar Gururaja writes: > rtc-omap driver modules is used both by OMAP1/2, Davinci SoC platforms. > > However, rtc wake support on OMAP1 is broken. Hence the > device_init_wakeup() was removed from rtc-omap driver and moved to > platform board files that supported it (DA850/OMAP-L138). [1] > > However, recently [2] it was suggested that driver should always do a > device_init_wakeup(dev, true). Platforms that don't want/need > wakeup support can disable it from userspace via: > > echo disabled > /sys/devices/.../power/wakeup > > Also, with the new DT boot-up, board file doesn't exist and hence there > is no way to have device wakeup support rtc. > > The fix for above issues, is to hard code device_init_wakeup() inside > driver and let platforms that don't need this, handle it through the > sysfs power entry. This series looks good now, thanks for your persistence. Kevin