From: Anthony Liguori <aliguori@us.ibm.com>
To: "Peter Maydell" <peter.maydell@linaro.org>,
"Andreas Färber" <afaerber@suse.de>
Cc: pbonzini@redhat.com, "open list:PowerPC" <qemu-ppc@nongnu.org>,
qemu-devel@nongnu.org, aurelien@aurel32.net,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH for-1.5?] target-ppc: Drop unnecessary dynamic cast in ppc_env_get_cpu()
Date: Fri, 10 May 2013 10:02:02 -0500 [thread overview]
Message-ID: <87sj1uzxn9.fsf@codemonkey.ws> (raw)
In-Reply-To: <CAFEAcA8QHAUDL_rEUP_nuMEwNX_ZW5eXnY=SVKNL+fYAWkFZJg@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On 10 May 2013 15:39, Andreas Färber <afaerber@suse.de> wrote:
>> A transition from CPUPPCState to PowerPCCPU can be considered safe,
>> just like PowerPCCPU::env access in the opposite direction.
>>
>> This should slightly improve interrupt performance.
>
>> static inline PowerPCCPU *ppc_env_get_cpu(CPUPPCState *env)
>> {
>> - return POWERPC_CPU(container_of(env, PowerPCCPU, env));
>> + return container_of(env, PowerPCCPU, env);
>> }
>
> So if this is worthwhile shouldn't we be doing it for
> all our CPUs?
Ack.
Regards,
Anthony Liguori
>
> thanks
> -- PMM
next prev parent reply other threads:[~2013-05-10 15:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 14:39 [Qemu-devel] [PATCH for-1.5?] target-ppc: Drop unnecessary dynamic cast in ppc_env_get_cpu() Andreas Färber
2013-05-10 14:42 ` Peter Maydell
2013-05-10 14:47 ` Andreas Färber
2013-05-10 15:07 ` Paolo Bonzini
2013-05-10 15:02 ` Anthony Liguori [this message]
2013-05-10 15:06 ` Anthony Liguori
2013-05-10 15:08 ` Paolo Bonzini
2013-05-10 15:54 ` Andreas Färber
[not found] ` <518D10E3.4080001@suse.de>
[not found] ` <14CF0363-E558-4387-A401-14C940131BDB@suse.de>
2013-05-10 16:14 ` Andreas Färber
2013-05-10 16:20 ` Peter Maydell
2013-05-10 16:40 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sj1uzxn9.fsf@codemonkey.ws \
--to=aliguori@us.ibm.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.