From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>,
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] wireless: fix Atheros drivers compilation
Date: Wed, 12 Dec 2012 19:32:13 +0200 [thread overview]
Message-ID: <87sj7bmb1e.fsf@qca.qualcomm.com> (raw)
In-Reply-To: <9038958.vZIvzVgBXq@lx-vladimir> (Vladimir Kondratiev's message of "Wed, 12 Dec 2012 19:25:16 +0200")
Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com> writes:
> OK, below same patch with explanation added. Good now?
Yup.
> From bb80d009b31c2b0751d156d6a653547107d490fa Mon Sep 17 00:00:00 2001
> From: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
> Date: Wed, 12 Dec 2012 10:56:09 +0200
> Subject: [PATCH v2] wireless: fix Atheros drivers compilation
>
> Bug introduced in commit:
> wireless: allow Atheros card to not depend on ath.ko
>
> Commit in question changed CONFIG_ATH_COMMON to CONFIG_ATH_CARDS as
> "Atheros card" indication in drivers/net/wireless/ath/Kconfig but it
> is used also by drivers/net/wireless/Makefile
>
> If there are only Atheros cards that do not require ATH_COMMON, whole
> Makefile for Atheros cards was not executed; and as result, driver
> won't compile in this case.
>
> Change in CONFIG_ option name should be reflected in the
> drivers/net/wireless/Makefile
>
> Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Tested-by: Kalle Valo <kvalo@qca.qualcomm.com>
John, so this patch should go to 3.8 as it's a regression.
Kalle
next prev parent reply other threads:[~2012-12-12 17:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 11:16 [PATCH v8 0/4] driver for 60g Wilocity chip wil6210 Vladimir Kondratiev
2012-11-15 11:16 ` [PATCH v8 1/4] wireless: Driver for 60GHz card wil6210 Vladimir Kondratiev
2012-11-15 11:17 ` [PATCH v8 2/4] wireless: allow Atheros card to not depend on ath.ko Vladimir Kondratiev
2012-11-21 11:18 ` Vladimir Kondratiev
2012-11-21 14:55 ` Kalle Valo
[not found] ` <CAB=NE6XP83QVZ8Vv1R247HLW3ep_quQ8yP9STKT5L_jMrpxUOA@mail.gmail.com>
2012-11-22 7:08 ` Kalle Valo
[not found] ` <CAB=NE6V2DTQD9Q2Chj0ftk4oYE1aykCJtCaeAu_WSp3RTVSjhA@mail.gmail.com>
2012-11-26 17:54 ` Vladimir Kondratiev
2012-11-28 13:55 ` Vladimir Kondratiev
2012-11-28 14:13 ` John W. Linville
2012-11-28 15:51 ` Vladimir Kondratiev
2012-11-28 15:53 ` [PATCH v2] " Vladimir Kondratiev
2012-11-28 16:59 ` Vladimir Kondratiev
[not found] ` <1585902.GCBvcuyASu@lx-vladimir>
2012-12-01 2:38 ` [RFC] How to manage dependency between patches John W. Linville
2012-12-02 8:14 ` Vladimir Kondratiev
2012-11-28 16:57 ` [PATCH v2] wireless: allow Atheros card to not depend on ath.ko Vladimir Kondratiev
2012-12-03 13:03 ` Vladimir Kondratiev
2012-12-03 13:46 ` John W. Linville
2012-12-04 7:59 ` Vladimir Kondratiev
2012-12-11 19:28 ` Kalle Valo
2012-12-12 8:07 ` Vladimir Kondratiev
2012-12-12 8:58 ` [PATCH] wireless: fix Atheros drivers compilation Vladimir Kondratiev
2012-12-12 17:08 ` Kalle Valo
2012-12-12 17:25 ` [PATCH v2] " Vladimir Kondratiev
2012-12-12 17:32 ` Kalle Valo [this message]
2012-11-15 11:17 ` [PATCH v8 3/4] wireless: integrate wil6210 driver into build Vladimir Kondratiev
2012-11-15 11:17 ` [PATCH v8 4/4] dynamic_debug: dynamic hex dump Vladimir Kondratiev
2012-11-15 11:52 ` Vladimir Kondratiev
2012-11-15 15:55 ` Andrei Emeltchenko
2012-11-15 17:32 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sj7bmb1e.fsf@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=qca_vkondrat@qca.qualcomm.com \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.