From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55008)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Td6Xm-0006Ha-Fe
	for qemu-devel@nongnu.org; Mon, 26 Nov 2012 16:48:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Td6Xl-0003ex-Cg
	for qemu-devel@nongnu.org; Mon, 26 Nov 2012 16:48:46 -0500
Received: from e28smtp09.in.ibm.com ([122.248.162.9]:54118)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Td6Xk-0003em-PC
	for qemu-devel@nongnu.org; Mon, 26 Nov 2012 16:48:45 -0500
Received: from /spool/local
	by e28smtp09.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aliguori@us.ibm.com>;
	Tue, 27 Nov 2012 03:18:42 +0530
Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66])
	by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	qAQLmdPb26607662
	for <qemu-devel@nongnu.org>; Tue, 27 Nov 2012 03:18:39 +0530
Received: from d28av04.in.ibm.com (loopback [127.0.0.1])
	by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	qAR3IUH7031248
	for <qemu-devel@nongnu.org>; Tue, 27 Nov 2012 14:18:30 +1100
From: Anthony Liguori <aliguori@us.ibm.com>
In-Reply-To: <50AE611A.50702@siemens.com>
References: <50AE611A.50702@siemens.com>
Date: Mon, 26 Nov 2012 15:48:31 -0600
Message-ID: <87sj7wrq6o.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH] chardev: Use real-time clock for open timer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Dietmar Maurer <dietmar@proxmox.com>, Luiz Capitulino <lcapitulino@redhat.com>

Jan Kiszka <jan.kiszka@siemens.com> writes:

> The vm clock may be stopped, and then we won't get open events anymore.
> Seen with QMP sessions.
>
> Reported-by: Dietmar Maurer <dietmar@proxmox.com>
> Tested-by: Luiz Capitulino <lcapitulino@redhat.com>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

Applied. Thanks.

Regards,

Anthony Liguori

> ---
>  qemu-char.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 88f4025..242b799 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -134,9 +134,9 @@ static void qemu_chr_fire_open_event(void *opaque)
>  void qemu_chr_generic_open(CharDriverState *s)
>  {
>      if (s->open_timer == NULL) {
> -        s->open_timer = qemu_new_timer_ms(vm_clock,
> +        s->open_timer = qemu_new_timer_ms(rt_clock,
>                                            qemu_chr_fire_open_event, s);
> -        qemu_mod_timer(s->open_timer, qemu_get_clock_ms(vm_clock) - 1);
> +        qemu_mod_timer(s->open_timer, qemu_get_clock_ms(rt_clock) - 1);
>      }
>  }
>  
> -- 
> 1.7.3.4