All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: "Greg KH" <gregkh@linuxfoundation.org>,
	Alex Lyashkov <umka@cloudlinux.com>
Cc: "LKML" <linux-kernel@vger.kernel.org>
Subject: lve module taint?
Date: Wed, 19 Sep 2012 11:32:40 +0930	[thread overview]
Message-ID: <87sjaepy67.fsf@rustcorp.com.au> (raw)

Hi all,

        I still have this patch sitting in my queue for next merge
window; I missed the previous one.  Is it still current?

Thanks,
Rusty.

From:	Matthew Garrett <mjg59@srcf.ucam.org>
Subject: module: taint kernel when lve module is loaded
Date: Fri, 22 Jun 2012 13:49:31 -0400

Cloudlinux have a product called lve that includes a kernel module. This
was previously GPLed but is now under a proprietary license, but the
module continues to declare MODULE_LICENSE("GPL") and makes use of some
EXPORT_SYMBOL_GPL symbols. Forcibly taint it in order to avoid this.

Signed-off-by: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Alex Lyashkov <umka@cloudlinux.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: stable@kernel.org
---
 kernel/module.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/kernel/module.c b/kernel/module.c
index 4edbd9c..9ad9ee9 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2730,6 +2730,10 @@ static int check_module_license_and_versions(struct module *mod)
 	if (strcmp(mod->name, "driverloader") == 0)
 		add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
 
+	/* lve claims to be GPL but upstream won't provide source */
+	if (strcmp(mod->name, "lve") == 0)
+		add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
+
 #ifdef CONFIG_MODVERSIONS
 	if ((mod->num_syms && !mod->crcs)
 	    || (mod->num_gpl_syms && !mod->gpl_crcs)

             reply	other threads:[~2012-09-19  5:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-19  2:02 Rusty Russell [this message]
2012-09-19  5:58 ` lve module taint? Michael Tokarev
2012-09-19  7:19   ` Greg KH
2012-09-19 22:59     ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sjaepy67.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=gregkh@linuxfoundation.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=umka@cloudlinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.