From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Stniy-0003uQ-HA for qemu-devel@nongnu.org; Tue, 24 Jul 2012 18:37:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Stnix-0002ww-AH for qemu-devel@nongnu.org; Tue, 24 Jul 2012 18:37:04 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:52434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StnX2-0007Yv-9G for qemu-devel@nongnu.org; Tue, 24 Jul 2012 18:24:44 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 24 Jul 2012 18:24:08 -0400 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 0785638C803A for ; Tue, 24 Jul 2012 18:24:05 -0400 (EDT) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6OMO4ot324640 for ; Tue, 24 Jul 2012 18:24:04 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6OMO4A4000630 for ; Tue, 24 Jul 2012 19:24:04 -0300 From: Anthony Liguori In-Reply-To: <1343150454-4677-12-git-send-email-mdroth@linux.vnet.ibm.com> References: <1343150454-4677-1-git-send-email-mdroth@linux.vnet.ibm.com> <1343150454-4677-12-git-send-email-mdroth@linux.vnet.ibm.com> Date: Tue, 24 Jul 2012 17:24:01 -0500 Message-ID: <87sjcgkdby.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 11/22] qapi: add open-coded visitor for struct tm types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , qemu-devel@nongnu.org Cc: quintela@redhat.com, owasserm@redhat.com, yamahata@valinux.co.jp, pbonzini@redhat.com, akong@redhat.com, afaerber@suse.de Michael Roth writes: Reviewed-by: Anthony Liguori Regards, Anthony Liguori > Signed-off-by: Michael Roth > --- > qapi/Makefile.objs | 1 + > qapi/misc-qapi-visit.c | 14 ++++++++++++++ > qapi/qapi-visit-core.h | 3 +++ > 3 files changed, 18 insertions(+) > create mode 100644 qapi/misc-qapi-visit.c > > diff --git a/qapi/Makefile.objs b/qapi/Makefile.objs > index 5f5846e..7604b52 100644 > --- a/qapi/Makefile.objs > +++ b/qapi/Makefile.objs > @@ -1,3 +1,4 @@ > qapi-obj-y = qapi-visit-core.o qapi-dealloc-visitor.o qmp-input-visitor.o > qapi-obj-y += qmp-output-visitor.o qmp-registry.o qmp-dispatch.o > qapi-obj-y += string-input-visitor.o string-output-visitor.o opts-visitor.o > +qapi-obj-y += misc-qapi-visit.o > diff --git a/qapi/misc-qapi-visit.c b/qapi/misc-qapi-visit.c > new file mode 100644 > index 0000000..a44773d > --- /dev/null > +++ b/qapi/misc-qapi-visit.c > @@ -0,0 +1,14 @@ > +#include > +#include "qidl.h" > + > +void visit_type_tm(Visitor *v, struct tm *obj, const char *name, Error **errp) > +{ > + visit_start_struct(v, NULL, "struct tm", name, 0, errp); > + visit_type_int32(v, &obj->tm_year, "tm_year", errp); > + visit_type_int32(v, &obj->tm_mon, "tm_mon", errp); > + visit_type_int32(v, &obj->tm_mday, "tm_mday", errp); > + visit_type_int32(v, &obj->tm_hour, "tm_hour", errp); > + visit_type_int32(v, &obj->tm_min, "tm_min", errp); > + visit_type_int32(v, &obj->tm_sec, "tm_sec", errp); > + visit_end_struct(v, errp); > +} > diff --git a/qapi/qapi-visit-core.h b/qapi/qapi-visit-core.h > index 4a7bdb6..6af9f5e 100644 > --- a/qapi/qapi-visit-core.h > +++ b/qapi/qapi-visit-core.h > @@ -100,4 +100,7 @@ void visit_start_array(Visitor *v, void **obj, const char *name, > void visit_next_array(Visitor *v, Error **errp); > void visit_end_array(Visitor *v, Error **errp); > > +/* misc. visitors */ > +void visit_type_tm(Visitor *m, struct tm *obj, const char *name, Error **errp); > + > #endif > -- > 1.7.9.5