From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 05/16] ARM: omap: fix vc.c PMIC error message Date: Wed, 08 Feb 2012 16:09:48 -0800 Message-ID: <87sjikx3xv.fsf@ti.com> References: <20120208163546.GA15849@n2100.arm.linux.org.uk> <20120208184539.GE29796@atomide.com> <87ty312ae0.fsf@ti.com> <20120208235358.GD16877@atomide.com> <20120208235620.GE25414@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog103.obsmtp.com ([74.125.149.71]:39554 "EHLO na3sys009aog103.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756886Ab2BIAJv (ORCPT ); Wed, 8 Feb 2012 19:09:51 -0500 Received: by mail-pw0-f51.google.com with SMTP id rp2so902319pbb.24 for ; Wed, 08 Feb 2012 16:09:50 -0800 (PST) In-Reply-To: <20120208235620.GE25414@n2100.arm.linux.org.uk> (Russell King's message of "Wed, 8 Feb 2012 23:56:20 +0000") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Russell King - ARM Linux Cc: Tony Lindgren , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Russell King - ARM Linux writes: > On Wed, Feb 08, 2012 at 03:53:58PM -0800, Tony Lindgren wrote: >> * Kevin Hilman [120208 14:35]: >> > Tony Lindgren writes: >> > >> > > * Russell King - ARM Linux [120208 08:06]: >> > >> While testing on my OMAP3430 platform, this error message was emitted: >> > >> >> > >> omap_vc_init_channel: PMIC info requried to configure vc forvdd_core not populated.Hence cannot initialize vc >> > >> >> > >> Trying to find this message was difficult because it was wrapped across >> > >> several lines. It also mis-spells "required", doesn't read very well, >> > >> and has spaces lacking. Let's replace it with a more concise: >> > >> >> > >> omap_vc_init_channel: No PMIC info for vdd_core >> > >> >> > >> While we're here, fix a simple spelling error in a comment. >> > >> >> > >> Signed-off-by: Russell King >> > > >> > > Acked-by: Tony Lindgren >> > >> > NAK. >> > >> > Tony, please use the patches already in your cleanup branch (that came >> > from my for_3.3/cleanup/pm) that fix this and also fix a similar problem >> > for VP. >> >> Ah OK, there's the VP part there too. >> >> So that would be the following two patches then for me to >> move to fixes from cleanup: >> >> cd63040e00ea83729673acfea1675d85fde6ea59 ARM: OMAP: voltage: cleanup VC/VP error messages >> af9a2ed9667b49e7e125eac526d8f655183ce53e ARM: OMAP2+: voltage: add check for missing PMIC info in VP init >> >> And patches 1 and 5 for Russell to drop then. >> >> Everybody OK with that? > > Does it fix the other issues I mention in the commit log as well? Like your patches 1 & 5, my series fixes the oops and also makes the error strings simple, non-wrapping ones. The one thing it doesn't fix is the spelling typo you fixed in the comment, but IMO we can leave that out for -rc. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Wed, 08 Feb 2012 16:09:48 -0800 Subject: [PATCH 05/16] ARM: omap: fix vc.c PMIC error message In-Reply-To: <20120208235620.GE25414@n2100.arm.linux.org.uk> (Russell King's message of "Wed, 8 Feb 2012 23:56:20 +0000") References: <20120208163546.GA15849@n2100.arm.linux.org.uk> <20120208184539.GE29796@atomide.com> <87ty312ae0.fsf@ti.com> <20120208235358.GD16877@atomide.com> <20120208235620.GE25414@n2100.arm.linux.org.uk> Message-ID: <87sjikx3xv.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Russell King - ARM Linux writes: > On Wed, Feb 08, 2012 at 03:53:58PM -0800, Tony Lindgren wrote: >> * Kevin Hilman [120208 14:35]: >> > Tony Lindgren writes: >> > >> > > * Russell King - ARM Linux [120208 08:06]: >> > >> While testing on my OMAP3430 platform, this error message was emitted: >> > >> >> > >> omap_vc_init_channel: PMIC info requried to configure vc forvdd_core not populated.Hence cannot initialize vc >> > >> >> > >> Trying to find this message was difficult because it was wrapped across >> > >> several lines. It also mis-spells "required", doesn't read very well, >> > >> and has spaces lacking. Let's replace it with a more concise: >> > >> >> > >> omap_vc_init_channel: No PMIC info for vdd_core >> > >> >> > >> While we're here, fix a simple spelling error in a comment. >> > >> >> > >> Signed-off-by: Russell King >> > > >> > > Acked-by: Tony Lindgren >> > >> > NAK. >> > >> > Tony, please use the patches already in your cleanup branch (that came >> > from my for_3.3/cleanup/pm) that fix this and also fix a similar problem >> > for VP. >> >> Ah OK, there's the VP part there too. >> >> So that would be the following two patches then for me to >> move to fixes from cleanup: >> >> cd63040e00ea83729673acfea1675d85fde6ea59 ARM: OMAP: voltage: cleanup VC/VP error messages >> af9a2ed9667b49e7e125eac526d8f655183ce53e ARM: OMAP2+: voltage: add check for missing PMIC info in VP init >> >> And patches 1 and 5 for Russell to drop then. >> >> Everybody OK with that? > > Does it fix the other issues I mention in the commit log as well? Like your patches 1 & 5, my series fixes the oops and also makes the error strings simple, non-wrapping ones. The one thing it doesn't fix is the spelling typo you fixed in the comment, but IMO we can leave that out for -rc. Kevin