From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Date: Thu, 12 Jan 2012 23:09:34 +0000 Subject: Re: [PATCH 3/15] i810: fix module_param bool abuse. Message-Id: <87sjjk34wx.fsf@rustcorp.com.au> List-Id: References: <874nx2tu1v.fsf@rustcorp.com.au> <4EEFC5B4.9000704@gmx.de> In-Reply-To: <4EEFC5B4.9000704@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Florian Tobias Schandinat Cc: lkml - Kernel Mailing List , Antonino Daplas , linux-fbdev@vger.kernel.org, Pawel Moll On Mon, 19 Dec 2011 23:16:04 +0000, Florian Tobias Schandinat wrote: > On 12/15/2011 03:03 AM, Rusty Russell wrote: > > The driver says "module_param(ddc3, bool, 0);". But it's not a used > > as a bool, it's used as a count. > > > > Make it a bool. > > > > Cc: Antonino Daplas > > Cc: Florian Tobias Schandinat > > Cc: linux-fbdev@vger.kernel.org > > Signed-off-by: Rusty Russell > > Applied. Hmm, I don't see this in Linus' tree yet, and it's a context-clash pre-requisite for part of the general driver bool conversion. I want to push today since I have linux.conf.au next week, so I've split the i810 conversion into a separate patch, below. It's been over a week in linux-next, can you push this please? From: Rusty Russell Subject: module_param: make bool parameters really bool (drivers/vidio/i810) module_param(bool) used to counter-intuitively take an int. In fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy trick. It's time to remove the int/unsigned int option. For this version it'll simply give a warning, but it'll break next kernel version. Signed-off-by: Rusty Russell diff --git a/drivers/video/i810/i810_main.c b/drivers/video/i810/i810_main.c --- a/drivers/video/i810/i810_main.c +++ b/drivers/video/i810/i810_main.c @@ -135,8 +135,8 @@ static struct pci_driver i810fb_driver static char *mode_option __devinitdata = NULL; static int vram __devinitdata = 4; static int bpp __devinitdata = 8; -static int mtrr __devinitdata; -static int accel __devinitdata; +static bool mtrr __devinitdata; +static bool accel __devinitdata; static int hsync1 __devinitdata; static int hsync2 __devinitdata; static int vsync1 __devinitdata; @@ -144,9 +144,9 @@ static int vsync2 __devinitdata; static int xres __devinitdata; static int yres; static int vyres __devinitdata; -static int sync __devinitdata; -static int extvga __devinitdata; -static int dcolor __devinitdata; +static bool sync __devinitdata; +static bool extvga __devinitdata; +static bool dcolor __devinitdata; static bool ddc3 __devinitdata; /*------------------------------------------------------------*/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756041Ab2ALXOA (ORCPT ); Thu, 12 Jan 2012 18:14:00 -0500 Received: from ozlabs.org ([203.10.76.45]:47500 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756013Ab2ALXN5 (ORCPT ); Thu, 12 Jan 2012 18:13:57 -0500 From: Rusty Russell To: Florian Tobias Schandinat Cc: lkml - Kernel Mailing List , Antonino Daplas , linux-fbdev@vger.kernel.org, Pawel Moll Subject: Re: [PATCH 3/15] i810: fix module_param bool abuse. In-Reply-To: <4EEFC5B4.9000704@gmx.de> References: <874nx2tu1v.fsf@rustcorp.com.au> <4EEFC5B4.9000704@gmx.de> User-Agent: Notmuch/0.6.1-1 (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu) Date: Fri, 13 Jan 2012 09:27:34 +1030 Message-ID: <87sjjk34wx.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Dec 2011 23:16:04 +0000, Florian Tobias Schandinat wrote: > On 12/15/2011 03:03 AM, Rusty Russell wrote: > > The driver says "module_param(ddc3, bool, 0);". But it's not a used > > as a bool, it's used as a count. > > > > Make it a bool. > > > > Cc: Antonino Daplas > > Cc: Florian Tobias Schandinat > > Cc: linux-fbdev@vger.kernel.org > > Signed-off-by: Rusty Russell > > Applied. Hmm, I don't see this in Linus' tree yet, and it's a context-clash pre-requisite for part of the general driver bool conversion. I want to push today since I have linux.conf.au next week, so I've split the i810 conversion into a separate patch, below. It's been over a week in linux-next, can you push this please? From: Rusty Russell Subject: module_param: make bool parameters really bool (drivers/vidio/i810) module_param(bool) used to counter-intuitively take an int. In fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy trick. It's time to remove the int/unsigned int option. For this version it'll simply give a warning, but it'll break next kernel version. Signed-off-by: Rusty Russell diff --git a/drivers/video/i810/i810_main.c b/drivers/video/i810/i810_main.c --- a/drivers/video/i810/i810_main.c +++ b/drivers/video/i810/i810_main.c @@ -135,8 +135,8 @@ static struct pci_driver i810fb_driver = static char *mode_option __devinitdata = NULL; static int vram __devinitdata = 4; static int bpp __devinitdata = 8; -static int mtrr __devinitdata; -static int accel __devinitdata; +static bool mtrr __devinitdata; +static bool accel __devinitdata; static int hsync1 __devinitdata; static int hsync2 __devinitdata; static int vsync1 __devinitdata; @@ -144,9 +144,9 @@ static int vsync2 __devinitdata; static int xres __devinitdata; static int yres; static int vyres __devinitdata; -static int sync __devinitdata; -static int extvga __devinitdata; -static int dcolor __devinitdata; +static bool sync __devinitdata; +static bool extvga __devinitdata; +static bool dcolor __devinitdata; static bool ddc3 __devinitdata; /*------------------------------------------------------------*/