From: Kevin Hilman <khilman@ti.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-omap@vger.kernel.org, paul@pwsan.com, b-cousson@ti.com
Subject: Re: [PATCHv10 05/14] OMAP2+: mux: add support for PAD wakeup interrupts
Date: Fri, 09 Dec 2011 15:13:19 -0800 [thread overview]
Message-ID: <87sjktjq40.fsf@ti.com> (raw)
In-Reply-To: <1323440857-385-6-git-send-email-t-kristo@ti.com> (Tero Kristo's message of "Fri, 9 Dec 2011 16:27:28 +0200")
Tero Kristo <t-kristo@ti.com> writes:
> OMAP mux now provides a service routine to parse pending wakeup events
> and to call registered ISR whenever active wakeups are detected.
Good.
> This routine is called directly from PRCM interrupt handler.
I think this comment is out of date with the code, since you're now
using a shared IRQ and the interrupt is directly called from the IRQ
core.
I'd update the changelog here just commenting on what this IRQ is shared
with, and how the interrupts are shared.
Also, a question on optimization. For every IO wakeup, this will go
through the list of *all* enabled hwmods. This could be pretty expensive
with lots of wakeups. Maybe we should have another flag for hwmods that
have wakeups enabled so walking the list of potential wakeup-capable
hwmods will be as fast as possible.
Kevin
next prev parent reply other threads:[~2011-12-09 23:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 14:27 [PATCHv10 00/14] PRCM chain handler Tero Kristo
2011-12-09 14:27 ` [PATCHv10 01/14] OMAP2+: hwmod: Add API to enable IO ring wakeup Tero Kristo
2011-12-09 14:27 ` [PATCHv10 02/14] OMAP2+: hwmod: Add API to check IO PAD wakeup status Tero Kristo
2011-12-09 14:27 ` [PATCHv10 03/14] omap: prm: add support for chain interrupt handler Tero Kristo
2011-12-09 14:27 ` [PATCHv10 04/14] omap: prm: add support for suspend prepare and finish callbacks Tero Kristo
2011-12-09 23:04 ` Kevin Hilman
2011-12-12 9:57 ` Tero Kristo
2011-12-09 14:27 ` [PATCHv10 05/14] OMAP2+: mux: add support for PAD wakeup interrupts Tero Kristo
2011-12-09 23:13 ` Kevin Hilman [this message]
2011-12-12 10:01 ` Tero Kristo
2011-12-12 15:07 ` Kevin Hilman
2011-12-09 14:27 ` [PATCHv10 06/14] omap3: pm: use prcm chain handler Tero Kristo
2011-12-09 23:23 ` Kevin Hilman
2011-12-12 9:55 ` Tero Kristo
2011-12-09 14:27 ` [PATCHv10 07/14] OMAP3: pm: do not enable PRCM MPU interrupts manually Tero Kristo
2011-12-09 14:27 ` [PATCHv10 08/14] TEMP: serial: added mux support Tero Kristo
2011-12-09 14:27 ` [PATCHv10 09/14] TEMP: 4430sdp: use common serial init with " Tero Kristo
2011-12-09 14:27 ` [PATCHv10 10/14] TEMP: mux: added trace for io wkup event Tero Kristo
2011-12-09 14:27 ` [PATCHv10 11/14] TEMP: OMAP3: pm: remove serial resume / idle calls from idle path Tero Kristo
2011-12-09 14:27 ` [PATCHv10 12/14] TEMP: OMAP3: serial: made serial to work properly with PRCM chain handler Tero Kristo
2011-12-09 14:27 ` [PATCHv10 13/14] TEMP: OMAP: serial: remove padconf hacks Tero Kristo
2011-12-09 14:27 ` [PATCHv10 14/14] TEMP: OMAP device: change pr_warnings to pr_debugs Tero Kristo
2011-12-09 22:36 ` [PATCHv10 00/14] PRCM chain handler Kevin Hilman
2011-12-12 9:56 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjktjq40.fsf@ti.com \
--to=khilman@ti.com \
--cc=b-cousson@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.