From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RO6dT-00014X-Al for qemu-devel@nongnu.org; Wed, 09 Nov 2011 06:48:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RO6dR-0005DU-Lu for qemu-devel@nongnu.org; Wed, 09 Nov 2011 06:48:07 -0500 Received: from e37.co.us.ibm.com ([32.97.110.158]:55525) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RO6dR-0005DM-Gd for qemu-devel@nongnu.org; Wed, 09 Nov 2011 06:48:05 -0500 Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 9 Nov 2011 04:48:03 -0700 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pA9Bm071151092 for ; Wed, 9 Nov 2011 04:48:00 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pA9BlxJj005365 for ; Wed, 9 Nov 2011 04:47:59 -0700 From: "Aneesh Kumar K.V" In-Reply-To: <87vcqt7c6g.fsf@linux.vnet.ibm.com> References: <1320834838-14623-1-git-send-email-avi@redhat.com> <87vcqt7c6g.fsf@linux.vnet.ibm.com> Date: Wed, 09 Nov 2011 17:17:49 +0530 Message-ID: <87sjlx7c0q.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 1.0 v2] configure: fix detection for xattr.h on modern distributions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity , Anthony Liguori , qemu-devel@nongnu.org On Wed, 09 Nov 2011 17:14:23 +0530, "Aneesh Kumar K.V" wrote: > On Wed, 9 Nov 2011 12:33:58 +0200, Avi Kivity wrote: > > Modern distributions place xattr.h in /usr/include/sys, and fold > > libattr.so into libc. They also don't have an ENOATTR. > > > > Make configure detect this, and add a qemu-xattr.h file that > > directs the #include to the right place. > > > > Signed-off-by: Avi Kivity > > --- > > > > v2: try for libc first, libattr second > > > > configure | 12 ++++++++++-- > > hw/9pfs/virtio-9p-handle.c | 2 +- > > hw/9pfs/virtio-9p-local.c | 2 +- > > hw/9pfs/virtio-9p-posix-acl.c | 2 +- > > hw/9pfs/virtio-9p-xattr.h | 2 +- > > linux-user/syscall.c | 2 +- > > qemu-xattr.h | 30 ++++++++++++++++++++++++++++++ > > 7 files changed, 45 insertions(+), 7 deletions(-) > > create mode 100644 qemu-xattr.h > > > > diff --git a/configure b/configure > > index 9e5da44..401d9a6 100755 > > --- a/configure > > +++ b/configure > > @@ -129,6 +129,7 @@ xen="" > > xen_ctrl_version="" > > linux_aio="" > > attr="" > > +libattr="" > > xfs="" > > > > vhost_net="no" > > @@ -1961,12 +1962,16 @@ if test "$attr" != "no" ; then > > cat > $TMPC < > #include > > #include > > -#include > > +#include > > int main(void) { getxattr(NULL, NULL, NULL, 0); setxattr(NULL, NULL, NULL, 0, 0); return 0; } > > EOF > > - if compile_prog "" "-lattr" ; then > > + if compile_prog "" "" ; then > > + attr=yes > > + # Older distros have , and need -lattr: > > + elif sed -i s,sys/xattr,attr/xattr, $TMPC && compile_prog "" "-lattr" ; then > > attr=yes > > LIBS="-lattr $LIBS" > > + libattr=yes > > else > > if test "$attr" = "yes" ; then > > feature_not_found "ATTR" > > @@ -3032,6 +3037,9 @@ fi > > if test "$attr" = "yes" ; then > > echo "CONFIG_ATTR=y" >> $config_host_mak > > fi > > +if test "$libattr" = "yes" ; then > > + echo "CONFIG_LIBATTR=y" >> $config_host_mak > > +fi > > Is this needed ? We are adding -lattr to LIBS if needed. What will > CONFIG_LIBATTR helps us to achieve ? > Ignore that you are using that in qemu-xattr.h -aneesh