diff for duplicates of <87sjo8ttwf.fsf@ti.com> diff --git a/a/1.txt b/N1/1.txt index 77a4b8d..24760f4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,14 +1,14 @@ "DebBarma, Tarun Kanti" <tarun.kanti@ti.com> writes: > [...] ->>> + /* ->>> + * If this is the first gpio_request for the bank, ->>> + * enable the bank module. ->>> + */ ->>> + if (!bank->mod_usage) ->>> + if (IS_ERR_VALUE(pm_runtime_get_sync(bank->dev) < 0)) { +>>> + ? ? /* +>>> + ? ? ?* If this is the first gpio_request for the bank, +>>> + ? ? ?* enable the bank module. +>>> + ? ? ?*/ +>>> + ? ? if (!bank->mod_usage) +>>> + ? ? ? ? ? ? if (IS_ERR_VALUE(pm_runtime_get_sync(bank->dev) < 0)) { >> ->> All of the IS_ERR_VALUE() usage is wrong here. You're checking if the +>> All of the IS_ERR_VALUE() usage is wrong here. ?You're checking if the >> result of IS_ERR_VALUE() is < 0 which will never happen. > No. > IS_ERR_VALUE is applied on the return value of pm_runtime_get_sync @@ -20,8 +20,3 @@ The result of the '< 0' check will be zero or one, so IS_ERR_VALUE() will never be true. Kevin - -_______________________________________________ -linux-arm-kernel mailing list -linux-arm-kernel@lists.infradead.org -http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N1/content_digest index 2ee1a0d..e97d153 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,28 +2,23 @@ "ref\01314798161-19523-18-git-send-email-tarun.kanti@ti.com\0" "ref\087ehztxmcg.fsf@ti.com\0" "ref\0CAC83Zv+sX1G4saFsU=bOUYjedcM6eYEOCVMKqMZ-5pxkBc6x2A@mail.gmail.com\0" - "From\0Kevin Hilman <khilman@ti.com>\0" - "Subject\0Re: [PATCH v6 17/25] gpio/omap: use pm-runtime framework\0" + "From\0khilman@ti.com (Kevin Hilman)\0" + "Subject\0[PATCH v6 17/25] gpio/omap: use pm-runtime framework\0" "Date\0Wed, 07 Sep 2011 05:32:32 -0700\0" - "To\0DebBarma" - " Tarun Kanti <tarun.kanti@ti.com>\0" - "Cc\0tony@atomide.com" - linux-omap@vger.kernel.org - linux-arm-kernel@lists.infradead.org - " Charulatha V <charu@ti.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "\"DebBarma, Tarun Kanti\" <tarun.kanti@ti.com> writes:\n" "\n" "> [...]\n" - ">>> + \302\240 \302\240 /*\n" - ">>> + \302\240 \302\240 \302\240* If this is the first gpio_request for the bank,\n" - ">>> + \302\240 \302\240 \302\240* enable the bank module.\n" - ">>> + \302\240 \302\240 \302\240*/\n" - ">>> + \302\240 \302\240 if (!bank->mod_usage)\n" - ">>> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 if (IS_ERR_VALUE(pm_runtime_get_sync(bank->dev) < 0)) {\n" + ">>> + ? ? /*\n" + ">>> + ? ? ?* If this is the first gpio_request for the bank,\n" + ">>> + ? ? ?* enable the bank module.\n" + ">>> + ? ? ?*/\n" + ">>> + ? ? if (!bank->mod_usage)\n" + ">>> + ? ? ? ? ? ? if (IS_ERR_VALUE(pm_runtime_get_sync(bank->dev) < 0)) {\n" ">>\n" - ">> All of the IS_ERR_VALUE() usage is wrong here. \302\240You're checking if the\n" + ">> All of the IS_ERR_VALUE() usage is wrong here. ?You're checking if the\n" ">> result of IS_ERR_VALUE() is < 0 which will never happen.\n" "> No.\n" "> IS_ERR_VALUE is applied on the return value of pm_runtime_get_sync\n" @@ -34,11 +29,6 @@ "The result of the '< 0' check will be zero or one, so IS_ERR_VALUE()\n" "will never be true.\n" "\n" - "Kevin\n" - "\n" - "_______________________________________________\n" - "linux-arm-kernel mailing list\n" - "linux-arm-kernel@lists.infradead.org\n" - http://lists.infradead.org/mailman/listinfo/linux-arm-kernel + Kevin -0cddb636e1abbdb22fbaa310e99a5902961a8b091c112786c6cbd27c14406ca7 +0bceb90fbb81a6bb69b2b3eb65b7735cd13b1eadaf109785f193b20c14ade3b6
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.