From: Kevin Hilman <khilman@ti.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: Grant Likely <grant.likely@secretlab.ca>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 3.1-rc3] gpio/omap: fix build error with certain OMAP1 configs
Date: Tue, 23 Aug 2011 10:11:47 -0700 [thread overview]
Message-ID: <87sjoshx2k.fsf@ti.com> (raw)
In-Reply-To: <201108231342.25101.jkrzyszt@tis.icnet.pl> (Janusz Krzysztofik's message of "Tue, 23 Aug 2011 13:42:24 +0200")
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> writes:
> With commit f64ad1a0e21a, "gpio/omap: cleanup _set_gpio_wakeup(), remove
> ifdefs", access to build time conditionally omitted 'suspend_wakeup'
> member of the 'gpio_bank' structure has been placed unconditionally in
> function _set_gpio_wakeup(), which is always built. This resulted in the
> driver compilation broken for certain OMAP1, i.e., non-OMAP16xx,
> configurations.
>
> Really required or not in previously excluded cases, define this
> structure member unconditionally as a fix.
>
> Tested with a custom OMAP1510 only configuration.
>
> Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Verified that this fixes a build problem when building for OMAP1
(730/850 only)
Acked-by: Kevin Hilman <khilman@ti.com>
Grant, can you queue this as a fix for 3.1-rc?
Thanks,
Kevin
next prev parent reply other threads:[~2011-08-23 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 11:42 [PATCH 3.1-rc3] gpio/omap: fix build error with certain OMAP1 configs Janusz Krzysztofik
2011-08-23 17:11 ` Kevin Hilman [this message]
2011-10-07 12:30 ` Janusz Krzysztofik
2011-10-10 21:12 ` Aaro Koskinen
[not found] ` <87fwiz8okk.fsf@ti.com>
2011-10-13 17:42 ` Grant Likely
2011-10-13 17:47 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjoshx2k.fsf@ti.com \
--to=khilman@ti.com \
--cc=grant.likely@secretlab.ca \
--cc=jkrzyszt@tis.icnet.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.