All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] toochain/crosstool-NG: bump version
Date: Sun, 07 Aug 2011 21:27:37 +0200	[thread overview]
Message-ID: <87sjpdkonq.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1312744789-21603-2-git-send-email-yann.morin.1998@anciens.enib.fr> (Yann E. MORIN's message of "Sun, 7 Aug 2011 21:19:48 +0200")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@anciens.enib.fr> writes:

Hi,

 Yann> +Makefile: allow recursion
 Yann> +
 Yann> +When crosstool-NG is used standalone, we completely avoid recursion,
 Yann> +because the Makefile calls itself only once.
 Yann> +
 Yann> +But when used as the buildroot toolchain backend, there is already
 Yann> +one level of make recursion when we first call the crosstool-NG
 Yann> +Makefile. And when buildroot is used out-of-tree, we are already
 Yann> +at the second level of recursion when calling the crosstool-NG
 Yann> +Makefile.
 Yann> +
 Yann> +So, to cope with the situation, only bail out at the 2nd level of
 Yann> +recursion, not the 0-th level.
 Yann> +
 Yann> +This probably won't go upstream.
 Yann> +
 Yann> +Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
 Yann> +
 Yann> +diff -durN crosstool-ng-1.12.0.orig//Makefile.in crosstool-ng-1.12.0/Makefile.in
 Yann> +--- crosstool-ng-1.12.0.orig//Makefile.in	2011-08-01 01:21:34.000000000 +0200
 Yann> ++++ crosstool-ng-1.12.0/Makefile.in	2011-08-07 14:37:02.678715954 +0200
 Yann> +@@ -95,7 +95,7 @@
 Yann> + # level.
 Yann> + # This has the side effect of only showing the real targets, and hiding our
 Yann> + # internal ones. :-)
 Yann> +-ifneq ($(MAKELEVEL),0)
 Yann> ++ifneq ($(MAKELEVEL),2)

Doesn't this then break for in-tree builds? How about just removing
these 3 lines instead?

 Yann> + $(error Recursion detected, bailing out...)
 Yann> + endif

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2011-08-07 19:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-07 19:19 [Buildroot] [PATCH 0/2] toolchain: update the crosstool-NG backend Yann E. MORIN
2011-08-07 19:19 ` [Buildroot] [PATCH 1/2] toochain/crosstool-NG: bump version Yann E. MORIN
2011-08-07 19:27   ` Peter Korsgaard [this message]
2011-08-07 19:36     ` Yann E. MORIN
2011-08-07 19:19 ` [Buildroot] [PATCH 2/2] toolchain/crosstool-NG: update bundled config files Yann E. MORIN
  -- strict thread matches above, loose matches on Subject: below --
2011-08-07 20:37 [Buildroot] [PATCH 0/2] toolchain: update the crosstool-NG backend, v2 Yann E. MORIN
2011-08-07 20:37 ` [Buildroot] [PATCH 1/2] toochain/crosstool-NG: bump version Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sjpdkonq.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.