From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH] drm/i915: fix errata for sync flush enable
	on 845G/830M
Date: Mon, 09 Aug 2010 14:10:20 -0700
Message-ID: <87sk2nlcg3.fsf@pollan.anholt.net>
References: <1281292780-28200-1-git-send-email-chris@chris-wilson.co.uk>
	<20100809094538.612f9f8a@virtuousgeek.org>
	<89k77n$ojogje@fmsmga001.fm.intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0685859804=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
In-Reply-To: <89k77n$ojogje@fmsmga001.fm.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

--===============0685859804==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Mon, 09 Aug 2010 18:04:50 +0100, Chris Wilson <chris@chris-wilson.co.uk>=
 wrote:
> On Mon, 9 Aug 2010 09:45:38 -0700, Jesse Barnes <jbarnes@virtuousgeek.org=
> wrote:
> > Is this hack even needed?  I noticed on my 945GM that INSTDONE has a
> > stuck bit when I use this code, removing it didn't seem to have any
> > negative effects...
>=20
> I'm not sure why we need to trigger a Sync on the GPU at this point, I
> just assumed it was one of those magic bits of code required to bring up
> the hardware.

Beginning a sync flush and continuing without waiting for the sync flush
to actually complete looks awfully bogus to me.  In the absence of
justification, I'd lean towards nuking this code.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkxgbrwACgkQHUdvYGzw6vcHCACeMh2QuRZ01yJrKhGPb6il8yLk
vXQAnRSXyPKoKVp5FtaHDLVK9k+ZUGyf
=r5xn
-----END PGP SIGNATURE-----
--=-=-=--

--===============0685859804==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============0685859804==--