From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 0/9] OMAP: DMTIMER: Convert platform driver so as to make use of hwmod + omap device framework for OMAP2 PLUS Date: Thu, 03 Jun 2010 16:46:28 -0700 Message-ID: <87sk53isrv.fsf@deeprootsystems.com> References: <1275143831-7629-1-git-send-email-thara@ti.com> <4C02E275.2080202@ti.com> <878w6vn4gu.fsf@deeprootsystems.com> <4C082CC3.80800@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pz0-f185.google.com ([209.85.222.185]:42287 "EHLO mail-pz0-f185.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756516Ab0FCXqb (ORCPT ); Thu, 3 Jun 2010 19:46:31 -0400 Received: by pzk15 with SMTP id 15so498249pzk.15 for ; Thu, 03 Jun 2010 16:46:30 -0700 (PDT) In-Reply-To: <4C082CC3.80800@ti.com> (Benoit's message of "Fri\, 04 Jun 2010 00\:29\:23 +0200") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Benoit Cc: "Gopinath, Thara" , "linux-omap@vger.kernel.org" , "tony@atomide.com" , "Sawant, Anand" Benoit writes: > On 6/4/2010 12:20 AM, Kevin Hilman wrote: >> Benoit Cousson writes: >> >>> On 5/29/2010 4:37 PM, Gopinath, Thara wrote: >>>> This patch series converts the OMAP Dual Mode Timer into a >>>> platform driver. This involves using of hwmod structures and >>>> omap_device layer for OMAP2/3/4 dmtimers and generic >>>> linux platform device layer for OMAP1. >>>> >>>> As a result of this patch series the dmtimer platform driver >>>> resides in arch/arm/plat-omap directory and arch specific >>>> implementations and device registerations reside in >>>> arch/arm/mach-omap1 and arch/arm/mach-omap2 for OMAP1 >>>> and OMAP2 PLUS respectively. >>> >>> Hi Thara, >>> >>> The Dual timer terminology is not used anymore since 2420. >>> It was replaced by gptimer and will be simplified going forward >>> using timer. This IP is almost the same since 1610, but will have 3 >>> different names. >>> It might be the good opportunity to align the names? >> >> If we were to align the names, what should be the "aligned" name? >> gptimer or timer? I tend to prefer gptimer as 'timer' is rather >> ambiguous in this context. > > Arrrgs, too late... After many discussions we agreed on 'timer' with > HW folks. Neither dmtimer not gptimer bring any useful > information. Timer that are not regular timers will have some prefix / > postfix like wd_ for the watchdog. And synctimer not being a timer at > all will then be renamed counter. > Why do you think 'timer' is ambiguous? Maybe vague is better than ambiguous. Timer is an all-encompasing term for all the things you mentioned above, as well as ARM-generic timers presumably coming down the road. I guess since this is in OMAP-specific code, 'timer' is fine, but it doesn't feel right. Maybe we need to call it 'omap_timer'.? Kevin