From: Michael Poole <mdpoole@troilus.org>
To: Benjamin Tissoires <tissoire@cena.fr>
Cc: Jiri Kosina <jkosina@suse.cz>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, Stephane Chatty <chatty@enac.fr>
Subject: Re: [PATCH 3/3] HID: deletion of unused code in hid-magicmouse.
Date: Mon, 08 Mar 2010 15:27:43 -0500 [thread overview]
Message-ID: <87sk8a36f4.fsf@troilus.org> (raw)
In-Reply-To: <4B952C77.3080505@cena.fr> (Benjamin Tissoires's message of "Mon, 08 Mar 2010 17:57:27 +0100")
Benjamin Tissoires writes:
>>
>> Well ... I don't see any patch titled "HID: deletion of unused code in
>> hid-magicmouse" neither in my inbox nor in my linux-input@ folder. Could
>> you perhaps please resend?
>>
>> Thanks,
>>
>
> Of course, I attached it. Do I need to send it in mbox format or is it ok ?
>
> Cheers,
> Benjamin
The recommended practice for sending patches is (from
Documentation/SubmittingPatches) "7) No MIME, no links, no compression,
no attachments. Just plain text."
I'm a bit mystified, though -- if magicmouse_setup_input() is from "the
old implementation", where is the new implementation? Jiri's
hid/for-next and hid/master trees definitely use the input device that
it sets up. The "magicmouse_input_mapping" function that shows up at
the end of your patch doesn't exist in those trees. The reason I didn't
use input_mapping() initially was because it only allows setting up one
input field, and the touch records generate multiple types of events.
Michael Poole
next prev parent reply other threads:[~2010-03-08 20:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1268065277-30129-1-git-send-email-tissoire@cena.fr>
[not found] ` <1268065277-30129-2-git-send-email-tissoire@cena.fr>
[not found] ` <1268065277-30129-3-git-send-email-tissoire@cena.fr>
[not found] ` <1268065277-30129-4-git-send-email-tissoire@cena.fr>
[not found] ` <1268065277-30129-5-git-send-email-tissoire@cena.fr>
2010-03-08 16:27 ` [PATCH 3/3] HID: deletion of unused code in hid-magicmouse Benjamin Tissoires
2010-03-08 16:30 ` Jiri Kosina
2010-03-08 16:57 ` Benjamin Tissoires
2010-03-08 20:27 ` Michael Poole [this message]
2010-03-08 20:51 ` Benjamin Tissoires
2010-03-08 23:56 ` Jiri Kosina
2010-03-09 12:00 ` Rantanplan
2010-03-10 15:09 ` Jiri Kosina
2010-03-10 15:39 ` Benjamin Tissoires
2010-03-08 21:29 Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sk8a36f4.fsf@troilus.org \
--to=mdpoole@troilus.org \
--cc=chatty@enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=tissoire@cena.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.