All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: romit@ti.com
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] PM: Prevent direct cpufreq scaling during initialization
Date: Wed, 16 Dec 2009 06:24:39 -0800	[thread overview]
Message-ID: <87skbbateg.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1259748759.21203.11.camel@boson> (Romit Dasgupta's message of "Wed\, 02 Dec 2009 15\:42\:39 +0530")

Romit Dasgupta <romit@ti.com> writes:

> It is seen that the OMAP specific cpufreq initialization code tries to
> scale the MPU frequency to the highest possible without taking care of
> the voltage level. On power on reset the power IC does not provide the
> necessary voltage for the highest available MPU frequency (that would
> satisfy all Si families). This potentially is an window of opportunity
> for things to go wrong.
>
> Signed-off-by: Romit Dasgupta <romit@ti.com>

Looks good.  Pulling into PM branch, and queing in pm-fixes for .33-rc
series.

Kevin

> ---
> diff --git a/arch/arm/plat-omap/cpu-omap.c b/arch/arm/plat-omap/cpu-omap.c
> index 449b6b6..f94df20 100644
> --- a/arch/arm/plat-omap/cpu-omap.c
> +++ b/arch/arm/plat-omap/cpu-omap.c
> @@ -149,8 +149,6 @@ static int __init omap_cpu_init(struct cpufreq_policy *policy)
>  							VERY_HI_RATE) / 1000;
>  	}
>  
> -	clk_set_rate(mpu_clk, policy->cpuinfo.max_freq * 1000);
> -
>  	policy->min = policy->cpuinfo.min_freq;
>  	policy->max = policy->cpuinfo.max_freq;
>  	policy->cur = omap_getspeed(0);

      parent reply	other threads:[~2009-12-16 14:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-02 10:12 [PATCH] PM: Prevent direct cpufreq scaling during initialization Romit Dasgupta
2009-12-02 15:33 ` Sergey Lapin
2009-12-03  6:29   ` Dasgupta, Romit
2009-12-03 10:09     ` Sergey Lapin
2009-12-04 10:47       ` Romit Dasgupta
2009-12-16 14:24 ` Kevin Hilman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87skbbateg.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=romit@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.