From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] netkitftp: ftp client from netkit project
Date: Tue, 27 Oct 2009 15:34:02 +0100 [thread overview]
Message-ID: <87skd4dhyd.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20091027141842.GP30850@hiegel.fr> (hugues@hiegel.fr's message of "Tue\, 27 Oct 2009 15\:18\:42 +0100")
>>>>> "Hugues" == Hugues <hugues@hiegel.fr> writes:
>> Thanks, looks a lot better, but we're still not quite there yet.
Hugues> aha :-)
;)
>> It would be good if you could add a signed-of-by line to the end of the
>> commit message - E.G.
>>
>> Signed-off-by: Hugues Hiegel <hugues.hiegel@openwide.fr>
Hugues> Well, perhaps should you be the really one who should answer me :
Hugues> what's the purpose of this "signed-off-by" !? :)
We're using the same system as the Linux kernel, so take a look at
section 12 of Documentation/SubmittingPatches in the kernel sources for
the details (http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches)
With git it's very easy to do - Simply add the -s argument to git
commit (or alternatively to git format-patch if you forgot while
committing).
Hugues> + "Classic" ftp client with standard behaviour from
>>
>> Trailing space.
Hugues> Argh, I *really* need to tweak my vim config to show these...
Not a big deal.
>> You'll also need to prepend netkitftp- to the patch names, as they will
>> otherwise not get applied and configure errors out on unrecognized
>> options.
Hugues> Mhm, it seemed to work correctly for me, I'll put another eye with more
Hugues> coffee ...
>> Are you testing this in some other tree than mainline?
Hugues> Yes, it's a tree that has been grown up from 2009.08_rc2, and
Hugues> I've got a bunch of configuration that work with. I should
Hugues> certainly consider getting a clean and correct config which
Hugues> works on top of the master branch (on which I cherry-pick my
Hugues> netkitftp tweaks ;))
That probably explains why you are seeing different things. We afaik
tightened up the patch handling since then to not apply *.patch* because
of packages supporting multiple versions.
Hugues> It'll take me some more days,
Hugues> I've got another bunch of things to do right now :(
Hugues> But I'm still not discouraged ;o)
;)
>> Could you fix those issues please?
Hugues> Oh yeah, no problem :)
Great!
Hugues> Thanks you a lot for your patience...
Same to you.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2009-10-27 14:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 16:17 [Buildroot] [PATCH] netkitftp: added package with Makefile.autotools.in support Hugues Hiegel
2009-10-26 16:17 ` Hugues Hiegel
2009-10-26 18:08 ` Peter Korsgaard
2009-10-26 21:15 ` Hugues
2009-10-26 22:00 ` Lionel Landwerlin
2009-10-27 9:35 ` Hugues
2009-10-26 22:03 ` Peter Korsgaard
2009-10-27 12:41 ` [Buildroot] [PATCH] netkitftp: ftp client from netkit project Hugues Hiegel
2009-10-27 12:46 ` Hugues
2009-10-27 13:48 ` Peter Korsgaard
2009-10-27 13:10 ` Peter Korsgaard
2009-10-27 14:18 ` Hugues
2009-10-27 14:34 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87skd4dhyd.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.