All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@nokia.com>
To: "Jouni Malinen" <j@w1.fi>
Cc: linux-wireless@vger.kernel.org
Subject: Re: Michael MIC failures in AP mode?
Date: Sat, 01 Nov 2008 17:45:06 +0200	[thread overview]
Message-ID: <87skqblabh.fsf@nokia.com> (raw)
In-Reply-To: <20081101151938.GA4857@jm.kir.nu> (ext Jouni Malinen's message of "Sat\, 1 Nov 2008 17\:19\:38 +0200")

"ext Jouni Malinen" <j@w1.fi> writes:

> On Sat, Nov 01, 2008 at 04:31:26PM +0200, Kalle Valo wrote:
>
>> Now that AP mode works in mac80211 I want to use it to test Michael
>> MIC failures in a wlan driver. Any recommendations, or tips, how to
>> easily create them with mac80211 and hostapd?
>
> There used to be test code for this in mac80211 that allowed testing of
> more or less all TKIP error cases (MIC error on TX/RX, ICV error on
> TX/RX, replay), but it looks like that has been mostly "cleaned up" be
> removal.. You might be able to find it from some old version..

Ok, I'll try to find it.

> Anyway, if you just want to test Michael MIC error processing on a
> client, force mac80211 to do software encryption and modify
> ieee80211_tx_h_michael_mic_add() in net/mac80211/wpa.c to insert an
> incorrect MIC (e.g., add mic[0]++; after the michael_mic() call). You
> will probably need a trigger mechanisms (say debugfs write) to enable
> this for a single TX frame in order to allow proper client testing.

Thanks, this is very helpful.

> Once I have some time, I could take a look at recovering the old design
> with a debugfs interface (it used to use private ioctl). It is useful to
> be able to test this type of things during development/system
> validation.

It sure is. I think I'm going to start using hostapd/mac80211 combo
for all my development, a simple configuration file and proper logs
are very handy compared to some crappy web interface. And having test
cases like artificial Michael MIC failure makes the system even
better.

I really hope that John can push the AP support to mainline during
next merge window :)

-- 
Kalle Valo

  reply	other threads:[~2008-11-01 15:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-01 14:31 Michael MIC failures in AP mode? Kalle Valo
2008-11-01 14:53 ` Johannes Berg
2008-11-01 15:19 ` Jouni Malinen
2008-11-01 15:45   ` Kalle Valo [this message]
2008-11-01 15:51   ` Johannes Berg
2008-11-01 16:06     ` Jouni Malinen
2008-11-01 16:06     ` Stefanik Gábor
2008-11-01 16:30     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87skqblabh.fsf@nokia.com \
    --to=kalle.valo@nokia.com \
    --cc=j@w1.fi \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.