From: "Markus Klotzbücher" <mk@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Remove duplicate #undef SHOW_INFO inside drivers\usb\usb_ohci.c
Date: Sun, 06 Apr 2008 14:51:28 +0200 [thread overview]
Message-ID: <87skxzuoxb.fsf@denx.de> (raw)
In-Reply-To: <5BF78BCE8D9BF14A83F836BD9E3916BA0DDAF5@blrms.slti.sanyo.co.in> (Gururaja Hebbar K. R.'s message of "Wed\, 2 Apr 2008 11\:04\:43 +0530")
Dear Gururaja,
"Gururaja Hebbar K R" <gururajakr@sanyo.co.in> writes:
> In drivers\usb\usb_ohci.c file, SHOW_INFO is undef at 2 locations.
> @line 77 and @line 112. Below patch removes them for code size savings.
>
> comments welcome.
Thank you, well spotted.
But, git-am fails for for two reasons:
1. It chokes on your HTML mail. Please send plain text.
> --- usb_orig.c 2007-12-06 01:21:19.000000000 -0800
> +++ usb_ohci.c 2008-04-02 14:06:23.937500000 -0700
> @@ -109,7 +109,6 @@ static struct pci_device_id ohci_pci_ids
> #define dbg(format, arg...) do {} while(0)
2. Please send a real diff containing the full path. Check the section
"Submitting Patches" in the README if unsure.
Please cleanup and resubmit.
Thanks!
Best regards
Markus Klotzbuecher
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2008-04-06 12:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-02 5:34 [U-Boot-Users] [PATCH] Remove duplicate #undef SHOW_INFO inside drivers\usb\usb_ohci.c Gururaja Hebbar K R
2008-04-06 12:51 ` Markus Klotzbücher [this message]
2008-04-18 4:14 ` Wolfgang Denk
2008-04-18 4:39 ` Gururaja Hebbar K R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87skxzuoxb.fsf@denx.de \
--to=mk@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.