All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] Add giflib package
Date: Thu, 13 Mar 2008 16:01:23 +0100	[thread overview]
Message-ID: <87skyu7jng.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <33858.69.65.92.49.1205197164.squirrel@webmail.learningsoft.net> (Sunil Gupta's message of "Mon\, 10 Mar 2008 20\:59\:24 -0400 \(EDT\)")

>>>>> "Sunil" == Sunil Gupta <sg@monsoon.com> writes:

Did you manually edit the patch? It was slightly corrupted (missing
newline at end)

Is this a replacement for libungif? Should we remove libungif?

Index: package/Config.in
===================================================================
--- package/Config.in	(revision 21284)
+++ package/Config.in	(working copy)
@@ -308,6 +308,7 @@
 comment "graphic libraries"
 source "package/directfb/Config.in"
 source "package/fusion/Config.in"
+source "package/giflib/Config.in"
 source "package/imagemagick/Config.in"
 source "package/jpeg/Config.in"
 source "package/libpng/Config.in"
Index: package/giflib/giflib.mk
===================================================================
--- package/giflib/giflib.mk	(revision 0)
+++ package/giflib/giflib.mk	(revision 0)
@@ -0,0 +1,60 @@
+#############################################################
+#
+# giflib
+#
+#############################################################
+GIFLIB_VERSION:=4.1.6
+GIFLIB_SOURCE:=giflib-$(GIFLIB_VERSION).tar.gz
+GIFLIB_SITE:=http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/giflib
+GIFLIB_DIR:=$(BUILD_DIR)/giflib-$(GIFLIB_VERSION)
+GIFLIB_BINARY:=lib/.libs/libgif.so
+GIFLIB_TARGET_BINARY:=usr/lib/libgif.so
+GIFLIB_INSTALL_DIR:=$(STAGING_DIR)
+
+$(DL_DIR)/$(GIFLIB_SOURCE):
+	$(WGET) -P $(DL_DIR) $(GIFLIB_SITE)/$(GIFLIB_SOURCE)
+
+$(GIFLIB_DIR)/.source: $(DL_DIR)/$(GIFLIB_SOURCE)
+	zcat $(DL_DIR)/$(GIFLIB_SOURCE) | tar -C $(BUILD_DIR) $(TAR_OPTIONS) -
+	touch $(GIFLIB_DIR)/.source

please use touch $@ instead.

+
+$(GIFLIB_DIR)/.configured: $(GIFLIB_DIR)/.source
+	(cd $(GIFLIB_DIR); \
+		$(TARGET_CONFIGURE_OPTS) \
+		CFLAGS="$(TARGET_CFLAGS)" \
+		./configure \
+		--target=$(GNU_TARGET_NAME) \
+		--host=$(GNU_TARGET_NAME) \
+		--prefix=$(GIFLIB_INSTALL_DIR) \
+		--disable-static \
+		--without-x \
+	);
+	touch $(GIFLIB_DIR)/.configured;

please use touch $@ instead.
+
+$(GIFLIB_DIR)/$(GIFLIB_BINARY): $(GIFLIB_DIR)/.configured
+	$(MAKE) CC=$(TARGET_CC) -C $(GIFLIB_DIR)
+
+$(TARGET_DIR)/$(GIFLIB_TARGET_BINARY): $(GIFLIB_DIR)/$(GIFLIB_BINARY)
+	$(MAKE) prefix=$(GIFLIB_INSTALL_DIR) -C $(GIFLIB_DIR) install
+	$(MAKE) prefix=$(GIFLIB_INSTALL_DIR) libdir=$(TARGET_DIR)/usr/lib -C $(GIFLIB_DIR) install

I think it would be clearer to split these two. With the above it
isn't clear that it does a full install into the staging dir and only
the libs into target.

+	rm -f $(TARGET_DIR)/usr/lib/libgif.la

There recently were some discussion about that - But lets leave it for
now ..

+
+giflib: uclibc $(TARGET_DIR)/$(GIFLIB_TARGET_BINARY)
+
+giflib-source: $(DL_DIR)/$(GIFLIB_SOURCE)
+
+giflib-clean:
+	$(MAKE) prefix=$(TARGET_DIR)/usr -C $(GIFLIB_DIR) uninstall

This fails if giflib hasn't been unpacked yet.

+	-$(MAKE) -C $(GIFLIB_DIR) clean
+
+giflib-dirclean:
+	rm -rf $(GIFLIB_DIR)
+
+#############################################################
+#
+# Toplevel Makefile options
+#
+#############################################################
+ifeq ($(strip $(BR2_PACKAGE_GIFLIB)),y)
+TARGETS+=giflib
+endif
Index: package/giflib/Config.in
===================================================================
--- package/giflib/Config.in	(revision 0)
+++ package/giflib/Config.in	(revision 0)
@@ -0,0 +1,17 @@
+config BR2_PACKAGE_GIFLIB
+	bool "giflib"
+	default n
+	help
+	  The giflib package contains libraries for reading
+	  and writing GIFs.
+
+	  http://sourceforge.net/projects/giflib
+
+config BR2_PACKAGE_GIFLIB_PROGRAMS

This isn't handled in the make file?

+	bool "giflib programs"
+	default n
+	depends on BR2_PACKAGE_GIFLIB
+	help
+	  The giflib programs are useful for conversion
+	  purposes as well as cleaning up images.
+
 Sunil> _______________________________________________
 Sunil> buildroot mailing list
 Sunil> buildroot at uclibc.org
 Sunil> http://busybox.net/mailman/listinfo/buildroot

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2008-03-13 15:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-11  0:59 [Buildroot] Add giflib package Sunil Gupta
2008-03-13 15:01 ` Peter Korsgaard [this message]
2008-03-13 15:14   ` Andrew Dyer
2008-03-13 16:09     ` Peter Korsgaard
2015-01-26 19:25       ` Bernd Kuhls

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87skyu7jng.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.