From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JIKCd-0001h1-0Y for mharc-grub-devel@gnu.org; Fri, 25 Jan 2008 03:46:23 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JIKCa-0001fl-NV for grub-devel@gnu.org; Fri, 25 Jan 2008 03:46:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JIKCY-0001f4-Ib for grub-devel@gnu.org; Fri, 25 Jan 2008 03:46:20 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JIKCX-0001ev-AQ for grub-devel@gnu.org; Fri, 25 Jan 2008 03:46:17 -0500 Received: from smtp-vbr9.xs4all.nl ([194.109.24.29]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JIKCW-00027a-RV for grub-devel@gnu.org; Fri, 25 Jan 2008 03:46:17 -0500 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr9.xs4all.nl (8.13.8/8.13.8) with ESMTP id m0P8kFc3041397 for ; Fri, 25 Jan 2008 09:46:15 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <94a0ccbc0801231500g752f72acodc37c733726d8919@mail.gmail.com> <4798D42E.7030506@nic.fi> <1201199662.19286.4.camel@dv> <200801242219.55828.okuji@enbug.org> <20080124232738.GA31192@thorin> Mail-Copies-To: mgerards@xs4all.nl Date: Fri, 25 Jan 2008 09:47:37 +0100 In-Reply-To: <20080124232738.GA31192@thorin> (Robert Millan's message of "Fri, 25 Jan 2008 00:27:38 +0100") Message-ID: <87sl0ml2ae.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: /kern/file.c BUG X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2008 08:46:21 -0000 Robert Millan writes: > On Thu, Jan 24, 2008 at 10:19:55PM +0100, Yoshinori K. Okuji wrote: >> On Thursday 24 January 2008 19:34, Pavel Roskin wrote: >> > On Thu, 2008-01-24 at 20:08 +0200, Vesa J=E4=E4skel=E4inen wrote: >> > > Previous behavior was working correctly. You have to handle >> > > errorcodes >> > > at some point and that means when error is handled it is zeroed (or >> > > GRUB_ERR_NONE). So code is in callee where that loop was. >> > >> > I suggest that we never set grub_errno to 0 (except the initialization= ). >> > That would match the standard errno behavior: >> > >> > http://www.opengroup.org/onlinepubs/009695399/functions/errno.html >>=20 >> Marco is right. As you pointed out, our error handling is different from= errno=20 >> on Unix, but this is intentional, because I stole the model from GRUB Le= gacy=20 >> and Parted. > > Could you explain how is it supposed to work? There were clearly two bug= s, > which I "fixed" in grub_disk_open first, and in grub_file_open. The solu= tion > can be wrong, but the bugs still existed. Hopefully my previous mail makes that clear? Were these previous problems committed? What is the bug? -- Marco