From mboxrd@z Thu Jan  1 00:00:00 1970
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: 32-on-64: pvfb issue
Date: Wed, 24 Jan 2007 13:24:19 +0100
Message-ID: <87sle0obnw.fsf@pike.pond.sub.org>
References: <C1DA7F58.801A%keir@xensource.com> <45B60548.4060003@suse.de>
	<45B741B7.1080306@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <45B741B7.1080306@suse.de> (Gerd Hoffmann's message of "Wed,
	24 Jan 2007 12:23:35 +0100")
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Gerd Hoffmann <kraxel@suse.de>
Cc: Xen devel list <xen-devel@lists.xensource.com>, Keir Fraser <keir@xensource.com>
List-Id: xen-devel@lists.xenproject.org

Gerd Hoffmann <kraxel@suse.de> writes:

[...]
> The pvfb backend has a stupid tyops (missing underscore) which breaks
> the combination 32bit dom0 and 64bit domU.  Fix attached.  The patch
> also adds a cast to fix a warning.
>
> please apply,
>
>   Gerd
>
> -- 
> Gerd Hoffmann <kraxel@suse.de>
> Index: build-32-release304-13133/tools/xenfb/xenfb.c
> ===================================================================
> --- build-32-release304-13133.orig/tools/xenfb/xenfb.c
> +++ build-32-release304-13133/tools/xenfb/xenfb.c
[...]
> @@ -560,10 +560,10 @@ int xenfb_attach_dom(struct xenfb *xenfb
>  	if (xenfb_wait_for_frontend_initialised(&xenfb->kbd) < 0)
>  		goto error;
>  
> -	if (xenfb_bind(&xenfb->fb) < 0)
> -		goto error;
>  	if (xenfb_bind(&xenfb->kbd) < 0)
>  		goto error;
> +	if (xenfb_bind(&xenfb->fb) < 0)
> +		goto error;
>  
>  	if (xenfb_xs_scanf1(xsh, xenfb->fb.otherend, "feature-update",
>  			    "%d", &val) < 0)

Why is this patch hunk necessary?