From: Markus Armbruster <armbru@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org, eblake@redhat.com, michael.roth@amd.com
Subject: Re: [PATCH] qapi/control: Turn the reference to qmp-spec.rst into a link
Date: Tue, 29 Sep 2026 06:43:38 +0200 [thread overview]
Message-ID: <87tsn83bwl.fsf@pond.sub.org> (raw)
In-Reply-To: <CAFn=p-bv4rF_VzVPQBLvcNxrnbvJDNpsAHQR9_iH1q0coc7rig@mail.gmail.com> (John Snow's message of "Mon, 28 Sep 2026 14:03:07 -0400")
John Snow <jsnow@redhat.com> writes:
> On Mon, Sep 28, 2026 at 2:32 AM Markus Armbruster <armbru@redhat.com> wrote:
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> qapi/control.json | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/qapi/control.json b/qapi/control.json
>> index 9898552814..c56aabacff 100644
>> --- a/qapi/control.json
>> +++ b/qapi/control.json
>> @@ -46,7 +46,7 @@
>> # connection, used for agreeing on particular QMP extension behaviors.
>> #
>> # @oob: QMP ability to support out-of-band requests. (Please refer to
>> -# qmp-spec.rst for more information on OOB)
>> +# :doc:`/interop/qmp-spec` for more information on OOB)
>> #
>> # Since: 2.12
>> ##
>> --
>> 2.55.0
>>
>
> I have a similar patch coming up in my rework of the @oob feature that:
>
> (1) Adds an anchor to the OOB section of the qmp spec explicitly,
> (2) Uses a standard form text with the above reference when generating
> docs for commands with the @oob property.
>
> The second doesn't apply to this command as it's an arg and not a
> feature/property; but we can do better and link directly to the OOB
> section of the spec doc.
I'm glad I cc'ed you. Would you like me to drop this patch? Or should
I merge it, and you improve on top?
next prev parent reply other threads:[~2026-09-29 4:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 6:32 [PATCH] qapi/control: Turn the reference to qmp-spec.rst into a link Markus Armbruster
2026-09-28 18:03 ` John Snow
2026-09-29 4:43 ` Markus Armbruster [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-09-29 19:24 John Snow
2026-10-05 19:32 ` Eric Blake
2026-10-07 18:42 ` John Snow
2026-10-08 4:28 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tsn83bwl.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.