All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Ahmed Naseef <naseefkm@gmail.com>
Cc: linux-mtd@lists.infradead.org,
	 Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: spinand: Only touch the QE bit on chips that have one
Date: Sun, 20 Sep 2026 15:30:45 +0200	[thread overview]
Message-ID: <87tsnk82yi.fsf@bootlin.com> (raw)
In-Reply-To: <20260910155355.3534491-1-naseefkm@gmail.com> (Ahmed Naseef's message of "Thu, 10 Sep 2026 19:53:55 +0400")

Hi Ahmed,

On 10/09/2026 at 19:53:55 +04, Ahmed Naseef <naseefkm@gmail.com> wrote:

> Since commit be0b86c648bf ("mtd: spinand: Gather all the bus interface
> steps in one single function") spinand_init_quad_enable() is called
> unconditionally and clears bit 0 of the configuration register even on
> chips without SPINAND_HAS_QE_BIT. On such chips that bit can have another
> meaning: on the Winbond W25N02KV it is H-DIS (Hold Disable, default 1),
> and clearing it enables the /HOLD function, after which erase and program
> operations silently stop taking effect on MT7986 boards.
>
> Only program the QE bit when the chip declares SPINAND_HAS_QE_BIT, as
> before.

Sorry for the breakage and thanks for the fix, unfortunately it arrived
just after another commit -which I am about to apply now-, therefore I
must take the first patch sent visible there:

https://lore.kernel.org/linux-mtd/010701a08d7e1638-79aaf1ea-cc8c-49e8-ba74-cba028aaa183-000000@eu-central-1.amazonses.com/

Is is very close to your proposal.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      reply	other threads:[~2026-09-20 13:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10 15:53 [PATCH] mtd: spinand: Only touch the QE bit on chips that have one Ahmed Naseef
2026-09-20 13:30 ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tsnk82yi.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=naseefkm@gmail.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.