From: Jonathan Corbet <corbet@lwn.net>
To: Karl Mehltretter <kmehltretter@gmail.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
Petr Mladek <pmladek@suse.com>
Cc: Karl Mehltretter <kmehltretter@gmail.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
live-patching@vger.kernel.org, linux-doc@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] Documentation: livepatch: Point klp_callbacks kernel-doc at livepatch_external.h
Date: Mon, 07 Sep 2026 09:49:03 -0600 [thread overview]
Message-ID: <87tso1vz80.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20260905085438.40349-1-kmehltretter@gmail.com>
Karl Mehltretter <kmehltretter@gmail.com> writes:
> api.rst asks include/linux/livepatch.h for struct klp_callbacks.
> Commit dd590d4d57eb ("objtool/klp: Introduce klp diff subcommand for
> diffing object files") moved the structure and its kernel-doc comment
> to include/linux/livepatch_external.h. Since then the Object Types
> section renders the other four structures but not klp_callbacks.
>
> Add a directive for the new header.
>
> Fixes: dd590d4d57eb ("objtool/klp: Introduce klp diff subcommand for diffing object files")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
> Documentation/livepatch/api.rst | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/livepatch/api.rst b/Documentation/livepatch/api.rst
> index 78944b63d74b..2a98c517da9d 100644
> --- a/Documentation/livepatch/api.rst
> +++ b/Documentation/livepatch/api.rst
> @@ -27,4 +27,7 @@ Object Types
> ============
>
> .. kernel-doc:: include/linux/livepatch.h
> - :identifiers: klp_patch klp_object klp_func klp_callbacks klp_state
> + :identifiers: klp_patch klp_object klp_func klp_state
> +
> +.. kernel-doc:: include/linux/livepatch_external.h
> + :identifiers: klp_callbacks
Applied, thanks.
jon
prev parent reply other threads:[~2026-09-07 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 8:54 [PATCH] Documentation: livepatch: Point klp_callbacks kernel-doc at livepatch_external.h Karl Mehltretter
2026-09-05 17:08 ` Randy Dunlap
2026-09-07 15:49 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tso1vz80.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=kmehltretter@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.