From: Takashi Iwai <tiwai@suse.de>
To: HyeongJun An <sammiee5311@gmail.com>
Cc: perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: dummy: Report a change when one capture switch channel moves
Date: Tue, 01 Sep 2026 18:26:31 +0200 [thread overview]
Message-ID: <87tso9aqfc.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260901153921.3971-1-sammiee5311@gmail.com>
On Tue, 01 Sep 2026 17:39:21 +0200,
HyeongJun An wrote:
>
> The snd_dummy_capsrc_put() builds its change flag with &&, so it reports
> a change only when both channels move at once. Writing a single channel
> stores the new value and returns 0, the control core then sends no
> SNDRV_CTL_EVENT_MASK_VALUE, and a second reader keeps showing the old
> setting until it polls again.
>
> The volume put a few lines above compares the same pair of channels with
> ||.
>
> The mixer selftest already reports this. With snd-dummy loaded it fails
> event_missing on all five capture switches:
>
> # CD Capture Switch.1 orig 0 read 1, is_volatile 0
> not ok 13 event_missing.Dummy.9
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Assisted-by: Claude:claude-opus-5
> Signed-off-by: HyeongJun An <sammiee5311@gmail.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-09-01 16:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 15:39 [PATCH] ALSA: dummy: Report a change when one capture switch channel moves HyeongJun An
2026-09-01 16:26 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tso9aqfc.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sammiee5311@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.