From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ADC625228C for ; Mon, 20 Jul 2026 14:02:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=166.70.13.232 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784556130; cv=none; b=RBFBZcvZq7vxqJT5fFqECY+gDRC8be4bT6v9pvpKvH08jQQtFvdKn5ENhwBwqqN++/TOsPkNL/57f8kIgYO0RQdpffL5M2alZ0rWDoFfroWBXVM20aqLgrZRsm4AcPPNNvP9CvXYl4ffYvVWBd2KaCESw4NH5G5EbJIx4g58XKo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784556130; c=relaxed/simple; bh=hCmcBr9WrdOfX4r9mgJweQ3HQ9G3nfIlF6XzZMoqjQ4=; h=From:To:Cc:In-Reply-To:References:Date:Message-ID:MIME-Version: Content-Type:Subject; b=ijZyC/7sZjXQq5HBSgfoZKkIonf7Vdg01qIN8LJsuwXZL7C2ybK6cvjHdfV1BOhcj5ZqlqA6yLpoS0Uu9fIlSfKXQhYk8TrUaIr2YQbm01K03FI8qLL0iSP3pWhEISPVnj+3NtJBHsPtbefZ7rJkafUVHIHOi20tz5LHwZo/BHw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xmission.com; spf=pass smtp.mailfrom=xmission.com; dkim=pass (1024-bit key) header.d=xmission.com header.i=@xmission.com header.b=Z2v98qJp; arc=none smtp.client-ip=166.70.13.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xmission.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xmission.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=xmission.com header.i=@xmission.com header.b="Z2v98qJp" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=xmission.com; s=xmission; h=Subject:Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hCmcBr9WrdOfX4r9mgJweQ3HQ9G3nfIlF6XzZMoqjQ4=; b=Z2v98qJpKz8dpENcUoCIsvoujd Oogmy9wkRw1+BowqQNdeVwVma5miPv+B769RZ8M8NLhBryycB6FmdVbetIWBFwzMyW8uMIpuqNqbq sqM2RbgfkueJaX+pXXknCcBF1kkvavoF4t7iB2i7WfW3u4TtzO+7vjbYmWHw9TRbDe1Y=; Received: from in02.mta.xmission.com ([166.70.13.52]:54944) by out02.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1wlnud-00DzgZ-8e; Mon, 20 Jul 2026 07:20:03 -0600 Received: from ip72-198-198-28.om.om.cox.net ([72.198.198.28]:36276 helo=email.froward.int.ebiederm.org.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1wlnub-00Ec9Q-DA; Mon, 20 Jul 2026 07:20:02 -0600 From: "Eric W. Biederman" To: "Cen Zhang (Microsoft)" Cc: brauner@kernel.org, oleg@redhat.com, akpm@linux-foundation.org, jack@suse.cz, avagin@gmail.com, ptikhomirov@virtuozzo.com, mjguzik@gmail.com, include@grrlz.net, legion@kernel.org, linux-kernel@vger.kernel.org, AutonomousCodeSecurity@microsoft.com, tgopinath@linux.microsoft.com, kys@microsoft.com In-Reply-To: <20260719155842.7069-1-blbllhy@gmail.com> (Cen Zhang's message of "Sun, 19 Jul 2026 11:58:41 -0400") References: <20260719155842.7069-1-blbllhy@gmail.com> Date: Mon, 20 Jul 2026 08:19:56 -0500 Message-ID: <87tsptu7b7.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1wlnub-00Ec9Q-DA;;;mid=<87tsptu7b7.fsf@email.froward.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=72.198.198.28;;;frm=ebiederm@xmission.com;;;sPfnum=0;;;sPf=pass X-XM-AID: U2FsdGVkX1/ofIHmrnlXuu9uAH4mDxgMJVLs5x7bBCc= X-Spam-Level: X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.1 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] * 0.4 FVGT_m_MULTI_ODD Contains multiple odd letter combinations * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;"Cen Zhang (Microsoft)" X-Spam-Relay-Country: X-Spam-Timing: total 1413 ms - load_scoreonly_sql: 0.07 (0.0%), signal_user_changed: 11 (0.8%), b_tie_ro: 10 (0.7%), parse: 1.53 (0.1%), extract_message_metadata: 19 (1.4%), get_uri_detail_list: 2.8 (0.2%), tests_pri_-2000: 6 (0.4%), tests_pri_-1000: 3.9 (0.3%), tests_pri_-950: 1.95 (0.1%), tests_pri_-900: 1.62 (0.1%), tests_pri_-90: 81 (5.7%), check_bayes: 79 (5.6%), b_tokenize: 13 (0.9%), b_tok_get_all: 8 (0.6%), b_comp_prob: 3.9 (0.3%), b_tok_touch_all: 49 (3.5%), b_finish: 1.05 (0.1%), tests_pri_0: 342 (24.2%), check_dkim_signature: 0.94 (0.1%), check_dkim_adsp: 3.4 (0.2%), poll_dns_idle: 908 (64.3%), tests_pri_10: 2.4 (0.2%), tests_pri_500: 936 (66.3%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH v3 1/2] pid: deinline kill_cad_pid X-SA-Exim-Connect-IP: 166.70.13.52 X-SA-Exim-Rcpt-To: kys@microsoft.com, tgopinath@linux.microsoft.com, AutonomousCodeSecurity@microsoft.com, linux-kernel@vger.kernel.org, legion@kernel.org, include@grrlz.net, mjguzik@gmail.com, ptikhomirov@virtuozzo.com, avagin@gmail.com, jack@suse.cz, akpm@linux-foundation.org, oleg@redhat.com, brauner@kernel.org, blbllhy@gmail.com X-SA-Exim-Mail-From: ebiederm@xmission.com X-SA-Exim-Scanned: No (on out02.mta.xmission.com); SAEximRunCond expanded to false "Cen Zhang (Microsoft)" writes: > Move kill_cad_pid() out of the header without changing behavior. This > prepares for taking a reference to cad_pid under RCU in the following > fix. nit: If you are going to uninline kill_cad_pid should be placed in signal.c not in pid.c That is where everything else that sends signals lives. Eric > Suggested-by: Mateusz Guzik > Suggested-by: Bradley Morgan > Reviewed-by: Bradley Morgan > Link: https://lore.kernel.org/all/CAGudoHH0vz=1m97EDHQFLLwGJmDPmqWJ+444b7rMiD059drEwQ@mail.gmail.com/ > Signed-off-by: Cen Zhang (Microsoft) > --- > v3: Add Reviewed-by from Bradley Morgan. > v2: New preparatory patch to deinline kill_cad_pid(). > > include/linux/sched/signal.h | 5 +---- > kernel/pid.c | 5 +++++ > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/include/linux/sched/signal.h b/include/linux/sched/signal.h > index 584ae88b435e..d45a5476b97d 100644 > --- a/include/linux/sched/signal.h > +++ b/include/linux/sched/signal.h > @@ -562,10 +562,7 @@ static inline sigset_t *sigmask_to_save(void) > return res; > } > > -static inline int kill_cad_pid(int sig, int priv) > -{ > - return kill_pid(cad_pid, sig, priv); > -} > +int kill_cad_pid(int sig, int priv); > > /* These can be the second arg to send_sig_info/send_group_sig_info. */ > #define SEND_SIG_NOINFO ((struct kernel_siginfo *) 0) > diff --git a/kernel/pid.c b/kernel/pid.c > index f55189a3d07d..234ebee29375 100644 > --- a/kernel/pid.c > +++ b/kernel/pid.c > @@ -557,6 +557,11 @@ pid_t pid_vnr(struct pid *pid) > } > EXPORT_SYMBOL_GPL(pid_vnr); > > +int kill_cad_pid(int sig, int priv) > +{ > + return kill_pid(cad_pid, sig, priv); > +} > + > pid_t __task_pid_nr_ns(struct task_struct *task, enum pid_type type, > struct pid_namespace *ns) > {