From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3ECFC43458 for ; Tue, 7 Jul 2026 07:27:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wh0Cj-0005jz-Pi; Tue, 07 Jul 2026 03:26:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wh0Cg-0005ji-AR for qemu-devel@nongnu.org; Tue, 07 Jul 2026 03:26:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wh0Cf-000681-1S for qemu-devel@nongnu.org; Tue, 07 Jul 2026 03:26:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783409208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LPIMqheyv6fbclbY7SZU+ebM5PYWzhXqrEq9yKr+kNw=; b=KES2lUMLkMHBgXzVmpq+id5iD7TvgOb2a/xQh3Timy+pkLMi3391gf6+q/wQPu17ft95L6 OEQMRGC0C1gXiYn1w5xu1tKhyook0nDFDn1MBlWITFJYW1ReS8iNfdXjqDMCDfk0msefhH W1J7ZE+1C6MEawWCD7qbrT7NV9JDXvs= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-480-f1ctQYiAOXa2dnabZukosw-1; Tue, 07 Jul 2026 03:26:44 -0400 X-MC-Unique: f1ctQYiAOXa2dnabZukosw-1 X-Mimecast-MFC-AGG-ID: f1ctQYiAOXa2dnabZukosw_1783409203 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F14921954B2F; Tue, 7 Jul 2026 07:26:42 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.4]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 708A31955F71; Tue, 7 Jul 2026 07:26:42 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 0C2A121E6920; Tue, 07 Jul 2026 09:26:40 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: qemu-devel@nongnu.org, Christian Brauner , devel@lists.libvirt.org, Alex =?utf-8?Q?Benn=C3=A9e?= , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , =?utf-8?Q?Marc-Andr?= =?utf-8?Q?=C3=A9?= Lureau , Paolo Bonzini , Peter Krempa , "Dr. David Alan Gilbert" Subject: Re: [PATCH v7 06/35] monitor: pass chardev ID into monitor constructor instead of object In-Reply-To: <20260706135824.2623960-7-berrange@redhat.com> ("Daniel P. =?utf-8?Q?Berrang=C3=A9=22's?= message of "Mon, 6 Jul 2026 14:57:54 +0100") References: <20260706135824.2623960-1-berrange@redhat.com> <20260706135824.2623960-7-berrange@redhat.com> Date: Tue, 07 Jul 2026 09:26:40 +0200 Message-ID: <87tsqbi7kf.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Daniel P. Berrang=C3=A9 writes: > Current the monitor_new_hmp/monitor_new_qmp constructors accept > a Chardev object pointer. To facilitate the next commit which will > introduce a QOM property for the character device ID, switch to > accepting an chardev ID in the constructor. > > Signed-off-by: Daniel P. Berrang=C3=A9 Split off a patch that got Marc-Andr=C3=A9's R-by. Marc-Andr=C3=A9, care t= o give it again?