From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDBC9C43458 for ; Tue, 7 Jul 2026 06:52:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgzer-0000N8-HG; Tue, 07 Jul 2026 02:51:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgzeo-0000Mp-Cm for qemu-devel@nongnu.org; Tue, 07 Jul 2026 02:51:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgzel-0004b3-LT for qemu-devel@nongnu.org; Tue, 07 Jul 2026 02:51:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783407106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/oSevnCojdo/qPQFLaryECoSKkM58NVacy1XfoNgCLY=; b=MRYCc86yQCpMnhi7UuXxBpfXWWce8cxf7Dr89QdcButo3l4abRCxm6K9dop8ZQ0xCIxRN6 uAxK6r+kOh7A8wzeCVclt/JUXasrLmkwtXR4eHCEGoDQuudWnwmtrOPQczBHznXz0uB0Ak rZixZq8d//gAZaf/j1bKFUbUt5dUGx8= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-206-ufQffvTpOziuwyvGNTQuJw-1; Tue, 07 Jul 2026 02:51:41 -0400 X-MC-Unique: ufQffvTpOziuwyvGNTQuJw-1 X-Mimecast-MFC-AGG-ID: ufQffvTpOziuwyvGNTQuJw_1783407100 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E5EEA1805C39; Tue, 7 Jul 2026 06:51:39 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.4]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D768E3000C00; Tue, 7 Jul 2026 06:51:38 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 68BD521E6920; Tue, 07 Jul 2026 08:51:36 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: qemu-devel@nongnu.org, Christian Brauner , devel@lists.libvirt.org, Alex =?utf-8?Q?Benn=C3=A9e?= , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , =?utf-8?Q?Marc-Andr?= =?utf-8?Q?=C3=A9?= Lureau , Paolo Bonzini , Peter Krempa , "Dr. David Alan Gilbert" Subject: Re: [PATCH v7 05/35] monitor: minimal conversion of monitors to QOM In-Reply-To: <20260706135824.2623960-6-berrange@redhat.com> ("Daniel P. =?utf-8?Q?Berrang=C3=A9=22's?= message of "Mon, 6 Jul 2026 14:57:53 +0100") References: <20260706135824.2623960-1-berrange@redhat.com> <20260706135824.2623960-6-berrange@redhat.com> Date: Tue, 07 Jul 2026 08:51:36 +0200 Message-ID: <87tsqbjnrb.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Daniel P. Berrang=C3=A9 writes: > This introduces abstract QOM type "monitor", with concrete subtypes > "monitor-hmp" and "monitor-qmp". This is the bare minimum conversion > of just the type declarations and replacing g_new/g_free with > object_new/object_unref. > > Command line option "-monitor" now creates a "monitor-hmp" object > "/objects/compat_monitorNNN" in addition to the character device > "/chardevs/compat_monitorNNN". NNN counts up from zero. > > Exception: "-monitor chardev:ID" creates a "monitor-hmp" object > "/objects/ID", and does not create a character device. > > "-qmp" and "-qmp-pretty" work the same, except they create a > "monitor-qmp" object. > > "-mon" now creates either a "monitor-hmp" or "monitor-qmp" object > "/objects/ID" if the option argument provides an ID, else > "/objects/compat_monitorNNN". > > "-gdbstub" and "-serial mon:..." now create a "monitor-hmp" object > "/objects/compat_monitorNNN". > > Note that the object's name in "/objects/" matches the QemuOpts ID when > it exists. The only cases where it doesn't exist are "-mon" without ID, > "-gdbstub" and "-serial mon:". > > A future patch will make "monitor-hmp" and "monitor-qmp" work with > "-object" and "object-add". > > Note: there is a slight change in the NNN values assigned. The old > code would increment the counter for every monitor added, regardless > of whether it needed a "compat_monitorNNN" ID assignment. Now it is > only incremented when an automatic ID assigned is needed, from any > of -mon, -gdbstub or -serial. This isn't quite right. The old code increments the counter for every monitor added with monitor_parse(), i.e. the monitors added with -monitor, -qmp, -qmp-pretty, and most default monitors. -mon, -serial mon:..., and -gdbstub don't use monitor_parse(). If we don't need a respin (which seems likely), I can amend this to Note: there is a slight change in the NNN values assigned. The old code would increment the counter for every monitor added (except for -mon, -serial mon:..., -gdbstub), regardless of whether it needed a "compat_monitorNNN" ID assignment. Now it is only incremented when an automatic ID assigned is needed (but even for -mon, -serial mon:..., -gdbstub). > Signed-off-by: Daniel P. Berrang=C3=A9