From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Simon Glass <sjg@chromium.org>, u-boot@lists.denx.de
Cc: Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v2 08/11] test: Add Args docstrings to img setup functions
Date: Mon, 08 Jun 2026 10:24:50 +0200 [thread overview]
Message-ID: <87tsrdxwvh.fsf@kernel.org> (raw)
In-Reply-To: <20260523085455.750591-9-sjg@chromium.org>
Hi Simon,
Thank you for the patch.
On Sat, May 23, 2026 at 02:54, Simon Glass <sjg@chromium.org> wrote:
> The image-setup functions in test/py/img/ have terse docstrings from
> their original location in test_ut.py
>
> Add an Args block describing the ubman parameter so each function is
> self-documenting.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
next prev parent reply other threads:[~2026-06-08 8:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 8:54 [PATCH v2 00/11] Move test/py image creation into separate modules Simon Glass
2026-05-23 8:54 ` [PATCH v2 01/11] test: Create a common file for image utilities Simon Glass
2026-06-08 8:04 ` Mattijs Korpershoek
2026-05-23 8:54 ` [PATCH v2 02/11] test: Move extlinux image-creation to its own file Simon Glass
2026-06-08 8:17 ` Mattijs Korpershoek
2026-05-23 8:54 ` [PATCH v2 03/11] test: Move script " Simon Glass
2026-06-08 8:13 ` Mattijs Korpershoek
2026-05-23 8:54 ` [PATCH v2 04/11] test: Move ChromeOS " Simon Glass
2026-06-08 8:19 ` Mattijs Korpershoek
2026-05-23 8:54 ` [PATCH v2 05/11] test: Move Android " Simon Glass
2026-06-08 8:21 ` Mattijs Korpershoek
2026-05-23 8:54 ` [PATCH v2 06/11] test: Move EFI " Simon Glass
2026-06-08 8:22 ` Mattijs Korpershoek
2026-05-23 8:54 ` [PATCH v2 07/11] test: Move the configuration-editor setup " Simon Glass
2026-06-08 8:23 ` Mattijs Korpershoek
2026-05-23 8:54 ` [PATCH v2 08/11] test: Add Args docstrings to img setup functions Simon Glass
2026-06-08 8:24 ` Mattijs Korpershoek [this message]
2026-05-23 8:54 ` [PATCH v2 09/11] test: Reformat line wraps in " Simon Glass
2026-06-08 8:27 ` Mattijs Korpershoek
2026-05-23 8:54 ` [PATCH v2 10/11] sandbox: Find disk images in the persistent-data directory Simon Glass
2026-06-08 8:41 ` Mattijs Korpershoek
2026-05-23 8:54 ` [PATCH v2 11/11] test: Move disk images to " Simon Glass
2026-06-08 8:49 ` Mattijs Korpershoek
2026-06-08 7:53 ` [PATCH v2 00/11] Move test/py image creation into separate modules Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tsrdxwvh.fsf@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.