From: "Alex Bennée" <alex.bennee@linaro.org>
To: Bin Guo <guobin@linux.alibaba.com>
Cc: qemu-devel@nongnu.org, "Warner Losh" <imp@bsdimp.com>,
"Kyle Evans" <kevans@freebsd.org>,
"Laurent Vivier" <laurent@vivier.eu>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [PATCH v2] util/cutils: drop qemu_strnlen() in favor of strnlen()
Date: Sat, 30 May 2026 14:29:20 +0100 [thread overview]
Message-ID: <87tsrpf2kv.fsf@draig.linaro.org> (raw)
In-Reply-To: <20260530062816.59206-1-guobin@linux.alibaba.com> (Bin Guo's message of "Sat, 30 May 2026 14:28:16 +0800")
Bin Guo <guobin@linux.alibaba.com> writes:
> There are only three call sites, and strnlen() is available on all
> supported platforms (POSIX.1-2008, Windows via UCRT, MinGW). Remove
> the hand-rolled wrapper and use the standard function directly.
>
> While here, align bsd-user/uaccess.c to use size_t for max_len/len,
> matching linux-user/uaccess.c and eliminating a signed/unsigned mismatch.
>
> Also remove the stale qemu_strnlen() entry from docs/devel/style.rst.
>
> Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Bin Guo <guobin@linux.alibaba.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2026-05-30 13:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 6:28 [PATCH v2] util/cutils: drop qemu_strnlen() in favor of strnlen() Bin Guo
2026-05-30 13:29 ` Alex Bennée [this message]
2026-05-30 13:40 ` Warner Losh
-- strict thread matches above, loose matches on Subject: below --
2026-05-29 8:39 [PATCH] " Philippe Mathieu-Daudé
2026-05-30 6:37 ` [PATCH v2] " Bin Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tsrpf2kv.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=guobin@linux.alibaba.com \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=laurent@vivier.eu \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.