From: Markus Armbruster <armbru@redhat.com>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, jasowang@redhat.com, lvivier@redhat.com,
sbrivio@redhat.com, samuel.thibault@ens-lyon.org
Subject: Re: [PATCH 3/4] qapi/net: Wean SLIRP off QAPI type String to improve documentation
Date: Thu, 21 May 2026 13:11:26 +0200 [thread overview]
Message-ID: <87tss1nhk1.fsf@pond.sub.org> (raw)
In-Reply-To: <177813267025.2413233.2433763734158027693.b4-review@b4> (marcandre lureau's message of "Thu, 07 May 2026 09:44:30 +0400")
marcandre.lureau@redhat.com writes:
> On Wed, 06 May 2026 12:54:20 +0200, Markus Armbruster <armbru@redhat.com> wrote:
>> String's doc comment is useless. Replace its use in NetdevUserOptions
>> by identical types with hopefully useful documentation.
>>
>> While there, add a non-doc commment explaining why the port forwarding
>> interface is problematic.
>
> commment -> comment
Fixed, thanks!
next prev parent reply other threads:[~2026-05-21 11:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 10:54 [PATCH 0/4] qapi/net: Some doc improvement and cleanup Markus Armbruster
2026-05-06 10:54 ` [PATCH 1/4] qapi/net: Rename NetDevPasstOptions to NetdevPasstOptions Markus Armbruster
2026-05-06 10:54 ` [PATCH 2/4] qapi/net: Wean passt off QAPI type String to improve documentation Markus Armbruster
2026-05-07 5:44 ` marcandre.lureau
2026-05-07 7:14 ` Markus Armbruster
2026-05-06 10:54 ` [PATCH 3/4] qapi/net: Wean SLIRP " Markus Armbruster
2026-05-07 5:44 ` marcandre.lureau
2026-05-21 11:11 ` Markus Armbruster [this message]
2026-05-06 10:54 ` [PATCH 4/4] qapi/net: Drop unused type String Markus Armbruster
2026-05-07 5:44 ` [PATCH 0/4] qapi/net: Some doc improvement and cleanup marcandre.lureau
2026-05-21 11:22 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tss1nhk1.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=jasowang@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.