Re: [PATCH v2] usb: gadget: Move USB_GADGET_DUALSPEED to be slightly more visible

[Mattijs Korpershoek <mkorpershoek@kernel.org>]

Hi Tom,

Thank you for the patch.

On Mon, Mar 23, 2026 at 08:32, Tom Rini <trini@konsulko.com> wrote:

> As exposed by "make randconfig", we have an issue around
> USB_GADGET_DUALSPEED. It is possible to select this symbol (via
> SPL_USB_CDNS3_GADGET for example) and so have an unmet dependency due to
> how this symbol is placed today. Move this to it's own section of the
> file guarded by USB_GADGET || SPL_USB_GADGET.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

> ---
> Changes in v2:
> - Implement this move as suggested by Marek instead
>
> Cc: Mattijs Korpershoek <mkorpershoek@kernel.org>
> Cc: Marek Vasut <marek.vasut+usb@mailbox.org>
> ---
>  drivers/usb/gadget/Kconfig | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index baa2eb61ea33..2f79840df18c 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -179,10 +179,6 @@ config SDP_LOADADDR
>  	hex "Default load address at SDP_WRITE and SDP_JUMP"
>  	default 0x0
>  
> -# Selected by UDC drivers that support high-speed operation.
> -config USB_GADGET_DUALSPEED
> -	bool
> -
>  config USB_GADGET_DOWNLOAD
>  	bool "Enable USB download gadget"
>  	help
> @@ -372,3 +368,11 @@ config SPL_SDP_USB_DEV
>  	  so it can be used in compiled environment.
>  
>  endif # SPL_USB_GADGET
> +
> +if USB_GADGET || SPL_USB_GADGET
> +
> +# Selected by UDC drivers that support high-speed operation.
> +config USB_GADGET_DUALSPEED
> +	bool
> +
> +endif
> -- 
> 2.43.0